refactor: replace str_ireplace() with in_array()

php > ini_set('display_errors', '1'); php > var_dump(ini_get('display_errors')); string(1) "1" php > ini_set('display_errors', 1); php > var_dump(ini_get('display_errors')); string(1) "1" php > ini_set('display_errors', true); php > var_dump(ini_get('display_errors')); string(1) "1" php > ini_set('display_errors', 'true'); php > var_dump(ini_get('display_errors')); string(4) "true"
codeigniter4 · Oct 26, 2023 · f251a3c · f251a3c
1 parent f26b9dc
commit f251a3c
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 10 deletions.
diff --git a/system/Debug/ExceptionHandler.php b/system/Debug/ExceptionHandler.php
@@ -130,11 +130,11 @@ protected function determineView(Throwable $exception, string $templatePath): st
         $view = 'production.php';
 
         if (
-            str_ireplace(
-                ['off', 'none', 'no', 'false', 'null', '0'],
-                '',
-                ini_get('display_errors')
-            ) !== ''
+            in_array(
+                strtolower(ini_get('display_errors')),
+                ['1', 'true', 'on', 'yes'],
+                true
+            )
         ) {
             $view = 'error_exception.php';
         }

diff --git a/system/Debug/Exceptions.php b/system/Debug/Exceptions.php
@@ -254,11 +254,11 @@ protected function determineView(Throwable $exception, string $templatePath): st
         $templatePath = rtrim($templatePath, '\\/ ') . DIRECTORY_SEPARATOR;
 
         if (
-            str_ireplace(
-                ['off', 'none', 'no', 'false', 'null', '0'],
-                '',
-                ini_get('display_errors')
-            ) !== ''
+            in_array(
+                strtolower(ini_get('display_errors')),
+                ['1', 'true', 'on', 'yes'],
+                true
+            )
         ) {
             $view = 'error_exception.php';
         }