Fix PostgreSQL getVersion() logic

codeigniter4 · May 12, 2023 · efbf68c · efbf68c
1 parent 42b174f
commit efbf68c
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 7 deletions.
diff --git a/phpstan-baseline.neon.dist b/phpstan-baseline.neon.dist
@@ -65,11 +65,6 @@ parameters:
 			count: 3
 			path: system/Database/MySQLi/PreparedQuery.php
 
-		-
-			message: "#^Strict comparison using \\=\\=\\= between array<string, int|string|null> and false will always evaluate to false\\.$#"
-			count: 1
-			path: system/Database/Postgre/Connection.php
-
 		-
 			message: "#^Access to an undefined property CodeIgniter\\\\Database\\\\BaseConnection\\:\\:\\$schema\\.$#"
 			count: 2

diff --git a/system/Database/Postgre/Connection.php b/system/Database/Postgre/Connection.php
@@ -128,11 +128,17 @@ public function getVersion(): string
             return $this->dataCache['version'];
         }
 
-        if (! $this->connID || ($pgVersion = pg_version($this->connID)) === false) {
+        if (! $this->connID) {
             $this->initialize();
         }
 
-        return isset($pgVersion['server']) ? $this->dataCache['version'] = $pgVersion['server'] : false;
+        $pgVersion = pg_version($this->connID);
+
+        if (! isset($pgVersion['server'])) {
+            return 'PostgreSQL 7.4 or lower';
+        }
+
+        return $this->dataCache['version'] = $pgVersion['server'];
     }
 
     /**