docs: add changelog

codeigniter4 · Sep 25, 2023 · c2829d9 · c2829d9
1 parent ef35fd9
commit c2829d9
Show file tree

Hide file tree

Showing 3 changed files with 33 additions and 0 deletions.
diff --git a/system/Commands/Database/ShowTableInfo.php b/system/Commands/Database/ShowTableInfo.php
@@ -102,6 +102,8 @@ public function run(array $params)
         $this->db       = Database::connect();
         $this->DBPrefix = $this->db->getPrefix();
 
+        $this->showDBConfig();
+
         $tables = $this->db->listTables();
 
         if (array_key_exists('desc', $params)) {
@@ -145,6 +147,22 @@ public function run(array $params)
         $this->showDataOfTable($tableName, $limitRows, $limitFieldValue);
     }
 
+    private function showDBConfig(): void
+    {
+        $data = [[
+            'hostname' => $this->db->hostname,
+            'database' => $this->db->database,
+            'username' => $this->db->username,
+            'DBDriver' => $this->db->DBDriver,
+            'DBPrefix' => $this->DBPrefix,
+            'port' => $this->db->port,
+        ]];
+        CLI::table(
+            $data, ['hostname', 'database', 'username', 'DBDriver', 'DBPrefix', 'port']
+        );
+
+    }
+
     private function removeDBPrefix(): void
     {
         $this->db->setPrefix('');

diff --git a/tests/system/Commands/Database/ShowTableInfoTest.php b/tests/system/Commands/Database/ShowTableInfoTest.php
@@ -183,4 +183,16 @@ public function testDbTableAllOptions(): void
             EOL;
         $this->assertStringContainsString($expected, $result);
     }
+
+    public function testDbTableWithInvalidDbConfig(): void
+    {
+        $config = config(Database::class);
+        $config->tests['database'] = 'invalid database name';
+
+        command('db:table --show');
+
+        $result = $this->getNormalizedResult();
+
+        dd($result);
+    }
 }
diff --git a/user_guide_src/source/changelogs/v4.4.2.rst b/user_guide_src/source/changelogs/v4.4.2.rst
@@ -30,6 +30,9 @@ Deprecations
 Bugs Fixed
 **********
 
+- **Spark:** Fixed a bug that caused spark to not display exceptions or to display
+  backtrace in json when an exception occurred.
+
 See the repo's
 `CHANGELOG.md <https://github.com/codeigniter4/CodeIgniter4/blob/develop/CHANGELOG.md>`_
 for a complete list of bugs fixed.