chore: remove @noRector

codeigniter4 · Dec 6, 2022 · bc333b8 · bc333b8
1 parent c53c1e5
commit bc333b8
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/rector.php b/rector.php
@@ -29,6 +29,7 @@
 use Rector\CodingStyle\Rector\FuncCall\CountArrayToEmptyArrayComparisonRector;
 use Rector\Config\RectorConfig;
 use Rector\DeadCode\Rector\ClassMethod\RemoveUnusedPrivateMethodRector;
+use Rector\DeadCode\Rector\ClassMethod\RemoveUselessReturnTagRector;
 use Rector\DeadCode\Rector\If_\UnwrapFutureCompatibleIfPhpVersionRector;
 use Rector\DeadCode\Rector\MethodCall\RemoveEmptyMethodCallRector;
 use Rector\EarlyReturn\Rector\Foreach_\ChangeNestedForeachIfsToEarlyContinueRector;
@@ -129,6 +130,11 @@
 
         // buggy on union mixed type, new class extends SomeClass marked as object in union, and false replaced with bool in Union
         TypedPropertyFromAssignsRector::class,
+
+        // rector mistakenly removes `@return true`
+        RemoveUselessReturnTagRector::class => [
+            __DIR__ . '/system/Debug/Exceptions.php',
+        ],
     ]);
 
     // auto import fully qualified class names

diff --git a/system/Debug/Exceptions.php b/system/Debug/Exceptions.php
@@ -378,11 +378,6 @@ private function isDeprecationError(int $error): bool
         return ($error & $deprecations) !== 0;
     }
 
-    /**
-     * @noRector \Rector\DeadCode\Rector\ClassMethod\RemoveUselessReturnTagRector
-     *
-     * @return true
-     */
     private function handleDeprecationError(string $message, ?string $file = null, ?int $line = null): bool
     {
         // Remove the trace of the error handler.