Ensure isn't checked during RouteCollection calls when called from CLI.

Fixes #1724
codeigniter4 · Feb 17, 2019 · b4df000 · b4df000
1 parent 6bf6403
commit b4df000
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/app/Config/Routes.php b/app/Config/Routes.php
@@ -74,6 +74,8 @@
 // route since we don't have to scan directories.
 $routes->get('/', 'Home::index');
 
+$routes->get('foo', 'Home::index', ['hostname' => 'foobar.com']);
+
 /**
  * --------------------------------------------------------------------
  * Additional Routing

diff --git a/system/Router/RouteCollection.php b/system/Router/RouteCollection.php
@@ -1250,7 +1250,7 @@ protected function create(string $verb, string $from, $to, array $options = null
 		if (! empty($options['hostname']))
 		{
 			// @todo determine if there's a way to whitelist hosts?
-			if (strtolower($_SERVER['HTTP_HOST']) !== strtolower($options['hostname']))
+			if (isset($_SERVER['HTTP_HOST']) && strtolower($_SERVER['HTTP_HOST']) !== strtolower($options['hostname']))
 			{
 				return;
 			}
@@ -1347,6 +1347,12 @@ protected function create(string $verb, string $from, $to, array $options = null
 	 */
 	private function checkSubdomains($subdomains)
 	{
+		// CLI calls can't be on subdomain.
+		if (! isset($_SERVER['HTTP_HOST']))
+		{
+			return false;
+		}
+
 		if (is_null($this->currentSubdomain))
 		{
 			$this->currentSubdomain = $this->determineCurrentSubdomain();