refactor: change parameter order

codeigniter4 · Jul 12, 2023 · b2e8c02 · b2e8c02
1 parent a131d6f
commit b2e8c02
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/system/HTTP/SiteURIFactory.php b/system/HTTP/SiteURIFactory.php
@@ -17,13 +17,13 @@
 
 class SiteURIFactory
 {
-    private Superglobals $superglobals;
     private App $appConfig;
+    private Superglobals $superglobals;
 
-    public function __construct(Superglobals $superglobals, App $appConfig)
+    public function __construct(App $appConfig, Superglobals $superglobals)
     {
-        $this->superglobals = $superglobals;
         $this->appConfig    = $appConfig;
+        $this->superglobals = $superglobals;
     }
 
     /**

diff --git a/tests/system/HTTP/SiteURIFactoryDetectRoutePathTest.php b/tests/system/HTTP/SiteURIFactoryDetectRoutePathTest.php
@@ -38,7 +38,7 @@ private function createSiteURIFactory(array $server, ?App $appConfig = null): Si
         $_SERVER      = $server;
         $superglobals = new Superglobals();
 
-        return new SiteURIFactory($superglobals, $appConfig);
+        return new SiteURIFactory($appConfig, $superglobals);
     }
 
     public function testDefault()

diff --git a/tests/system/HTTP/SiteURIFactoryTest.php b/tests/system/HTTP/SiteURIFactoryTest.php
@@ -36,7 +36,7 @@ private function createSiteURIFactory(?App $config = null, ?Superglobals $superg
         $config ??= new App();
         $superglobals ??= new Superglobals();
 
-        return new SiteURIFactory($superglobals, $config);
+        return new SiteURIFactory($config, $superglobals);
     }
 
     public function testCreateFromGlobals()