refactor: fix never empty array on Image

codeigniter4 · Dec 27, 2024 · 9805121 · 9805121
1 parent 8c62422
commit 9805121
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 10 deletions.
diff --git a/system/Images/Image.php b/system/Images/Image.php
@@ -104,7 +104,7 @@ public function getProperties(bool $return = false)
         $path = $this->getPathname();
         $vals = getimagesize($path);
 
-        if ($vals === [] || $vals === false) {
+        if ($vals === false) {
             throw ImageException::forFileNotSupported();
         }
 

diff --git a/utils/phpstan-baseline/identical.alwaysFalse.neon b/utils/phpstan-baseline/identical.alwaysFalse.neon
diff --git a/utils/phpstan-baseline/loader.neon b/utils/phpstan-baseline/loader.neon
@@ -28,7 +28,6 @@ includes:
     - generator.returnType.neon
     - generator.valueType.neon
     - greaterOrEqual.invalid.neon
-    - identical.alwaysFalse.neon
     - if.condNotBoolean.neon
     - isset.offset.neon
     - isset.property.neon