Merge pull request #5653 from kenjis/refactor-CLI-Incomming-Request

refactor: isCLI() in CLIRequest and IncomingRequest
codeigniter4 · Feb 16, 2022 · 93b8bca · 93b8bca
2 parents 048d997 + 873ba16
commit 93b8bca
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/system/HTTP/CLIRequest.php b/system/HTTP/CLIRequest.php
@@ -195,6 +195,6 @@ protected function parseCommand()
      */
     public function isCLI(): bool
     {
-        return is_cli();
+        return true;
     }
 }
diff --git a/system/HTTP/IncomingRequest.php b/system/HTTP/IncomingRequest.php
@@ -347,7 +347,7 @@ public function negotiate(string $type, array $supported, bool $strictMatch = fa
      */
     public function isCLI(): bool
     {
-        return is_cli();
+        return false;
     }
 
     /**

diff --git a/tests/system/HTTP/IncomingRequestTest.php b/tests/system/HTTP/IncomingRequestTest.php
@@ -439,8 +439,7 @@ public function testCanGrabGetRawInput()
 
     public function testIsCLI()
     {
-        // this should be the case in unit testing
-        $this->assertTrue($this->request->isCLI());
+        $this->assertFalse($this->request->isCLI());
     }
 
     public function testIsAJAX()
-Original file line number
+Diff line change
@@ Expand Up @@
          */
         public function isCLI(): bool
         {
-            return is_cli();
+            return false;
         }
         /**
@@ Expand Down @@