fix: ensure HTTP verb is lower case

HTTP verb in Router must be lower case.
codeigniter4 · Jun 6, 2023 · 8f8851c · 8f8851c
1 parent d94ebf3
commit 8f8851c
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/system/Router/AutoRouterImproved.php b/system/Router/AutoRouterImproved.php
@@ -111,7 +111,7 @@ public function __construct(// @phpstan-ignore-line
      */
     public function getRoute(string $uri, string $httpVerb): array
     {
-        $defaultMethod = $httpVerb . ucfirst($this->defaultMethod);
+        $defaultMethod = strtolower($httpVerb) . ucfirst($this->defaultMethod);
         $this->method  = $defaultMethod;
 
         $segments = explode('/', $uri);

diff --git a/system/Router/RouteCollection.php b/system/Router/RouteCollection.php
@@ -150,7 +150,7 @@ class RouteCollection implements RouteCollectionInterface
     /**
      * The current method that the script is being called by.
      *
-     * @var string
+     * @var string HTTP verb (lower case) or `*`
      */
     protected $HTTPVerb = '*';
 
@@ -550,11 +550,13 @@ public function getHTTPVerb(): string
      * Sets the current HTTP verb.
      * Used primarily for testing.
      *
+     * @param string $verb HTTP verb
+     *
      * @return $this
      */
     public function setHTTPVerb(string $verb)
     {
-        $this->HTTPVerb = $verb;
+        $this->HTTPVerb = strtolower($verb);
 
         return $this;
     }

diff --git a/system/Router/Router.php b/system/Router/Router.php
@@ -126,7 +126,7 @@ public function __construct(RouteCollectionInterface $routes, ?Request $request
         $this->controller = $this->collection->getDefaultController();
         $this->method     = $this->collection->getDefaultMethod();
 
-        $this->collection->setHTTPVerb(strtolower($request->getMethod() ?? $_SERVER['REQUEST_METHOD']));
+        $this->collection->setHTTPVerb($request->getMethod() ?? $_SERVER['REQUEST_METHOD']);
 
         $this->translateURIDashes = $this->collection->shouldTranslateURIDashes();