Merge pull request #7375 from kenjis/test-comment-out-testUnserialize…

…TimeObject test: Temporary solution for PHP 8.2.4 SIGSEGV
codeigniter4 · Mar 24, 2023 · 829bcb2 · 829bcb2
2 parents 0954e8a + 2508a76
commit 829bcb2
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 20 deletions.
diff --git a/tests/system/I18n/TimeLegacyTest.php b/tests/system/I18n/TimeLegacyTest.php
@@ -1124,16 +1124,17 @@ public function testGetter()
         $this->assertNull($time->weekOfWeek);
     }
 
-    public function testUnserializeTimeObject()
-    {
-        $time1     = new TimeLegacy('August 28, 2020 10:04:00pm', 'Asia/Manila', 'en');
-        $timeCache = serialize($time1);
-        $time2     = unserialize($timeCache);
-
-        $this->assertInstanceOf(TimeLegacy::class, $time2);
-        $this->assertTrue($time2->equals($time1));
-        $this->assertNotSame($time1, $time2);
-    }
+    // @TODO Uncomment when PHP 8.2.4 Segmentation fault fixed.
+//    public function testUnserializeTimeObject()
+//    {
+//        $time1     = new TimeLegacy('August 28, 2020 10:04:00pm', 'Asia/Manila', 'en');
+//        $timeCache = serialize($time1);
+//        $time2     = unserialize($timeCache);
+//
+//        $this->assertInstanceOf(TimeLegacy::class, $time2);
+//        $this->assertTrue($time2->equals($time1));
+//        $this->assertNotSame($time1, $time2);
+//    }
 
     public function testSetTestNowWithFaLocale()
     {

diff --git a/tests/system/I18n/TimeTest.php b/tests/system/I18n/TimeTest.php
@@ -1127,16 +1127,17 @@ public function testGetter()
         $this->assertNull($time->weekOfWeek);
     }
 
-    public function testUnserializeTimeObject()
-    {
-        $time1     = new Time('August 28, 2020 10:04:00pm', 'Asia/Manila', 'en');
-        $timeCache = serialize($time1);
-        $time2     = unserialize($timeCache);
-
-        $this->assertInstanceOf(Time::class, $time2);
-        $this->assertTrue($time2->equals($time1));
-        $this->assertNotSame($time1, $time2);
-    }
+    // @TODO Uncomment when PHP 8.2.4 Segmentation fault fixed.
+//    public function testUnserializeTimeObject()
+//    {
+//        $time1     = new Time('August 28, 2020 10:04:00pm', 'Asia/Manila', 'en');
+//        $timeCache = serialize($time1);
+//        $time2     = unserialize($timeCache);
+//
+//        $this->assertInstanceOf(Time::class, $time2);
+//        $this->assertTrue($time2->equals($time1));
+//        $this->assertNotSame($time1, $time2);
+//    }
 
     public function testSetTestNowWithTimeZone()
     {