fix. uri have '/' method is ''

codeigniter4 · May 12, 2020 · 7c8d3bf · 7c8d3bf
1 parent a063f14
commit 7c8d3bf
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/system/Router/Router.php b/system/Router/Router.php
@@ -534,7 +534,11 @@ public function autoRoute(string $uri)
 		// has already been set.
 		if (! empty($segments))
 		{
-			$this->method = array_shift($segments);
+			$tempMethod = array_shift($segments);
+			if ($tempMethod !== '')
+			{
+				$this->method = $tempMethod;
+			}
 		}
 
 		if (! empty($segments))

diff --git a/tests/system/Router/RouterTest.php b/tests/system/Router/RouterTest.php
@@ -520,4 +520,15 @@ public function testAutoRouteMatchesZeroParams()
 		];
 		$this->assertEquals($expected, $router->params());
 	}
+
+	/**
+	 * @see https://github.com/codeigniter4/CodeIgniter4/issues/2965
+	 */
+	public function testAutoRouteMethodEmpty()
+	{
+		$router = new Router($this->collection, $this->request);
+		$router->handle('Home/');
+		$this->assertEquals('Home', $router->controllerName());
+		$this->assertEquals('index', $router->methodName());
+	}
 }