fix form helper set_radio

codeigniter4 · Aug 2, 2018 · 6b6703d · 6b6703d
1 parent 25922b5
commit 6b6703d
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/system/Helpers/form_helper.php b/system/Helpers/form_helper.php
@@ -925,7 +925,7 @@ function set_radio(string $field, string $value = '', bool $default = false): st
 
 		// Unchecked checkbox and radio inputs are not even submitted by browsers ...
 		$result = '';
-		if (!empty($request->getPost()) || !empty(old($field)))
+		if (!empty($input = $request->getPost($field)) || !empty($input = old($field)))
 		{
 			$result = ($input === $value) ? ' checked="checked"' : '';
 		}

diff --git a/tests/system/Helpers/FormHelperTest.php b/tests/system/Helpers/FormHelperTest.php
@@ -756,6 +756,10 @@ public function testSetCheckbox()
 	}
 
 	// ------------------------------------------------------------------------
+	/**
+	 * @runInSeparateProcess
+	 * @preserveGlobalState disabled
+	 */
 	public function testSetRadio()
 	{
 		$_SESSION = [
@@ -771,6 +775,10 @@ public function testSetRadio()
 		unset($_SESSION['_ci_old_input']);
 	}
 
+	/**
+	 * @runInSeparateProcess
+	 * @preserveGlobalState disabled
+	 */
 	public function testSetRadioFromPost()
 	{
 		$_POST['bar'] = 'baz';