Merge remote-tracking branch 'upstream/develop' into 4.5

codeigniter4 · Oct 27, 2023 · 5e08ece · 5e08ece
2 parents 3aecb58 + 8409157
commit 5e08ece
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 10 deletions.
diff --git a/rector.php b/rector.php
@@ -16,6 +16,7 @@
 use Rector\CodeQuality\Rector\FuncCall\ChangeArrayPushToArrayAssignRector;
 use Rector\CodeQuality\Rector\FuncCall\SimplifyRegexPatternRector;
 use Rector\CodeQuality\Rector\FuncCall\SimplifyStrposLowerRector;
+use Rector\CodeQuality\Rector\FuncCall\SingleInArrayToCompareRector;
 use Rector\CodeQuality\Rector\FunctionLike\SimplifyUselessVariableRector;
 use Rector\CodeQuality\Rector\If_\CombineIfRector;
 use Rector\CodeQuality\Rector\If_\ShortenElseIfRector;
@@ -142,4 +143,5 @@
     $rectorConfig->rule(PrivatizeFinalClassPropertyRector::class);
     $rectorConfig->rule(CompleteDynamicPropertiesRector::class);
     $rectorConfig->rule(BooleanInIfConditionRuleFixerRector::class);
+    $rectorConfig->rule(SingleInArrayToCompareRector::class);
 };
diff --git a/system/Config/BaseService.php b/system/Config/BaseService.php
@@ -348,7 +348,7 @@ protected static function discoverServices(string $name, array $arguments)
                         continue;
                     }
 
-                    if (! in_array($classname, [Services::class], true)) {
+                    if ($classname !== Services::class) {
                         static::$services[] = new $classname();
                     }
                 }

diff --git a/system/Exceptions/FrameworkException.php b/system/Exceptions/FrameworkException.php
@@ -66,7 +66,7 @@ public static function forMissingExtension(string $extension)
                 'The framework needs the following extension(s) installed and loaded: %s.',
                 $extension
             );
-            // @codeCoverageIgnoreEnd
+        // @codeCoverageIgnoreEnd
         } else {
             $message = lang('Core.missingExtension', [$extension]);
         }

diff --git a/tests/system/Database/Live/GroupTest.php b/tests/system/Database/Live/GroupTest.php
@@ -40,7 +40,7 @@ public function testGroupBy(): void
 
     public function testHavingBy(): void
     {
-        $isANSISQL = in_array($this->db->DBDriver, ['OCI8'], true);
+        $isANSISQL = $this->db->DBDriver === 'OCI8';
 
         if ($isANSISQL) {
             $result = $this->db->table('job')
@@ -63,7 +63,7 @@ public function testHavingBy(): void
 
     public function testOrHavingBy(): void
     {
-        $isANSISQL = in_array($this->db->DBDriver, ['OCI8'], true);
+        $isANSISQL = $this->db->DBDriver === 'OCI8';
 
         if ($isANSISQL) {
             $result = $this->db->table('user')
@@ -134,7 +134,7 @@ public function testHavingNotIn(): void
 
     public function testOrHavingNotIn(): void
     {
-        $isANSISQL = in_array($this->db->DBDriver, ['OCI8'], true);
+        $isANSISQL = $this->db->DBDriver === 'OCI8';
 
         if ($isANSISQL) {
             $result = $this->db->table('job')
@@ -207,7 +207,7 @@ public function testOrHavingLike(): void
 
     public function testOrNotHavingLike(): void
     {
-        $isANSISQL = in_array($this->db->DBDriver, ['OCI8'], true);
+        $isANSISQL = $this->db->DBDriver === 'OCI8';
 
         if ($isANSISQL) {
             $result = $this->db->table('job')
@@ -237,7 +237,7 @@ public function testOrNotHavingLike(): void
 
     public function testAndHavingGroupStart(): void
     {
-        $isANSISQL = in_array($this->db->DBDriver, ['OCI8'], true);
+        $isANSISQL = $this->db->DBDriver === 'OCI8';
 
         if ($isANSISQL) {
             $result = $this->db->table('job')
@@ -271,7 +271,7 @@ public function testAndHavingGroupStart(): void
 
     public function testOrHavingGroupStart(): void
     {
-        $isANSISQL = in_array($this->db->DBDriver, ['OCI8'], true);
+        $isANSISQL = $this->db->DBDriver === 'OCI8';
 
         if ($isANSISQL) {
             $result = $this->db->table('job')
@@ -306,7 +306,7 @@ public function testOrHavingGroupStart(): void
 
     public function testNotHavingGroupStart(): void
     {
-        $isANSISQL = in_array($this->db->DBDriver, ['OCI8'], true);
+        $isANSISQL = $this->db->DBDriver === 'OCI8';
 
         if ($isANSISQL) {
             $result = $this->db->table('job')
@@ -340,7 +340,7 @@ public function testNotHavingGroupStart(): void
 
     public function testOrNotHavingGroupStart(): void
     {
-        $isANSISQL = in_array($this->db->DBDriver, ['OCI8'], true);
+        $isANSISQL = $this->db->DBDriver === 'OCI8';
 
         if ($isANSISQL) {
             $result = $this->db->table('job')