Merge pull request #793 from bcit-ci/feature/sqlite

Feature/sqlite

.travis.yml

@@ -21,6 +21,7 @@ dist: precise
 env:
   - DB=mysqli
   - DB=postgres
+  - DB=sqlite
 
 services:
   - memcached

php_errors.log

@@ -0,0 +1 @@
+[30-Jan-2018 23:57:36 America/Chicago] PHP Fatal error:  Class 'z' not found in /Users/kilishan/WebSites/CodeIgniter4/tests/system/Validation/RulesTest.php on line 5

phpunit.xml.dist

@@ -16,7 +16,10 @@
         </testsuite>
         <testsuite name="system">
             <directory>./tests/system</directory>
-            <!-- <exclude>./tests/system/Database/Live</exclude> -->
+            <exclude>./tests/system/Database</exclude>
+        </testsuite>
+        <testsuite name="database">
+            <directory>./tests/system/Database</directory>
         </testsuite>
     </testsuites>
 

system/Database/BaseBuilder.php

@@ -188,6 +188,21 @@ class BaseBuilder
 	 */
 	protected $binds = [];
 
+	/**
+	 * Some databases, like SQLite, do not by default
+	 * allow limiting of delete clauses.
+	 *
+	 * @var bool
+	 */
+	protected $canLimitDeletes = true;
+
+	/**
+	 * Some databases do not by default
+	 * allow limit update queries with WHERE.
+	 * @var bool
+	 */
+	protected $canLimitWhereUpdates = true;
+
 	//--------------------------------------------------------------------
 
 	/**
@@ -1908,6 +1923,11 @@ public function update($set = null, $where = null, int $limit = null, $test = fa
 
 		if ( ! empty($limit))
 		{
+			if (! $this->canLimitWhereUpdates)
+			{
+				throw new DatabaseException('This driver does not allow LIMITs on UPDATE queries using WHERE.');
+			}
+
 			$this->limit($limit);
 		}
 
@@ -2292,6 +2312,11 @@ public function delete($where = '', $limit = null, $reset_data = true, $returnSQ
 
 		if ( ! empty($this->QBLimit))
 		{
+			if (! $this->canLimitDeletes)
+			{
+				throw new DatabaseException('SQLite3 does not allow LIMITs on DELETE queries.');
+			}
+
 			$sql = $this->_limit($sql);
 		}