Use timestamp types for storing session timestamps

They are easier to work with than plain integers.
codeigniter4 · Sep 22, 2019 · 529b5ad · 529b5ad
1 parent 4b1774a
commit 529b5ad
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/system/Session/Handlers/DatabaseHandler.php b/system/Session/Handlers/DatabaseHandler.php
@@ -239,7 +239,7 @@ public function write($sessionID, $sessionData): bool
 			$insertData = [
 				'id'         => $sessionID,
 				'ip_address' => $this->ipAddress,
-				'timestamp'  => time(),
+				'timestamp'  => 'now()',
 				'data'       => $this->platform === 'postgre' ? '\x' . bin2hex($sessionData) : $sessionData,
 			];
 
@@ -262,7 +262,7 @@ public function write($sessionID, $sessionData): bool
 		}
 
 		$updateData = [
-			'timestamp' => time(),
+			'timestamp' => 'now()',
 		];
 
 		if ($this->fingerprint !== md5($sessionData))
@@ -345,7 +345,8 @@ public function destroy($sessionID): bool
 	 */
 	public function gc($maxlifetime): bool
 	{
-		return ($this->db->table($this->table)->delete('timestamp < ' . (time() - $maxlifetime))) ? true : $this->fail();
+		$interval = implode(" '"[(int)($this->platform === 'postgre')], ['', "{$maxlifetime} second", '']);
+		return ($this->db->table($this->table)->delete("timestamp < now() - INTERVAL {$interval}")) ? true : $this->fail();
 	}
 
 	//--------------------------------------------------------------------

diff --git a/user_guide_src/source/libraries/sessions.rst b/user_guide_src/source/libraries/sessions.rst
@@ -585,7 +585,7 @@ For MySQL::
 	CREATE TABLE IF NOT EXISTS `ci_sessions` (
 		`id` varchar(128) NOT NULL,
 		`ip_address` varchar(45) NOT NULL,
-		`timestamp` int(10) unsigned DEFAULT 0 NOT NULL,
+		`timestamp` timestamp DEFAULT CURRENT_TIMESTAMP NOT NULL,
 		`data` blob NOT NULL,
 		KEY `ci_sessions_timestamp` (`timestamp`)
 	);
@@ -595,7 +595,7 @@ For PostgreSQL::
 	CREATE TABLE "ci_sessions" (
 		"id" varchar(128) NOT NULL,
 		"ip_address" varchar(45) NOT NULL,
-		"timestamp" bigint DEFAULT 0 NOT NULL,
+		"timestamp" timestamptz DEFAULT CURRENT_TIMESTAMP NOT NULL,
 		"data" bytea DEFAULT '' NOT NULL
 	);