Cannot unpack arrays with string keys. Fixes #1057

codeigniter4 · Jun 7, 2018 · 2d5be73 · 2d5be73
1 parent 4f13dff
commit 2d5be73
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/system/HTTP/Response.php b/system/HTTP/Response.php
@@ -922,6 +922,9 @@ protected function sendCookies()
 
 		foreach ($this->cookies as $params)
 		{
+			// PHP cannot unpack array with string keys
+			$params = array_values($params);
+
 			setcookie(...$params);
 		}
 	}

diff --git a/system/Helpers/cookie_helper.php b/system/Helpers/cookie_helper.php
@@ -73,10 +73,7 @@ function set_cookie($name, string $value = '', string $expire = '', string $doma
 		// The following line shows as a syntax error in NetBeans IDE
 		//(\Config\Services::response())->setcookie
 		$response = \Config\Services::response();
-		$response->setcookie
-				(
-				$name, $value, $expire, $domain, $path, $prefix, $secure, $httpOnly
-		);
+		$response->setcookie($name, $value, $expire, $domain, $path, $prefix, $secure, $httpOnly);
 	}
 
 }