fix: handing fragment

codeigniter4 · Feb 17, 2023 · 2a0e22c · 2a0e22c
1 parent df5bf35
commit 2a0e22c
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 0 deletions.
diff --git a/system/HTTP/SiteURI.php b/system/HTTP/SiteURI.php
@@ -125,6 +125,7 @@ public function __construct(
 
         // Set routePath
         $parts     = explode('?', $relativePath);
+        $parts     = explode('#', $parts[0]);
         $routePath = $parts[0];
         $this->setRoutePath($routePath);
     }

diff --git a/tests/system/HTTP/SiteURITest.php b/tests/system/HTTP/SiteURITest.php
@@ -58,6 +58,30 @@ public function testConstructorRelativePathWithQuery()
         $this->assertSame('foo=1&bar=2', $uri->getQuery());
     }
 
+    public function testConstructorRelativePathWithFragment()
+    {
+        $config = new App();
+
+        $uri = new SiteURI($config, 'one/two#sec1');
+
+        $this->assertSame('http://example.com/index.php/one/two#sec1', (string) $uri);
+        $this->assertSame('/index.php/one/two', $uri->getPath());
+        $this->assertSame('', $uri->getQuery());
+        $this->assertSame('sec1', $uri->getFragment());
+    }
+
+    public function testConstructorRelativePathWithQueryAndFragment()
+    {
+        $config = new App();
+
+        $uri = new SiteURI($config, 'one/two?foo=1&bar=2#sec1');
+
+        $this->assertSame('http://example.com/index.php/one/two?foo=1&bar=2#sec1', (string) $uri);
+        $this->assertSame('/index.php/one/two', $uri->getPath());
+        $this->assertSame('foo=1&bar=2', $uri->getQuery());
+        $this->assertSame('sec1', $uri->getFragment());
+    }
+
     public function testConstructorHost()
     {
         $config                   = new App();