Fix escape and add changelog

codeigniter4 · Aug 26, 2022 · 297bd3b · 297bd3b
1 parent 5da4fcd
commit 297bd3b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/system/Database/SQLSRV/Forge.php b/system/Database/SQLSRV/Forge.php
@@ -147,7 +147,7 @@ protected function _alterTable(string $alterType, string $table, $field)
             $fullTable = $this->db->escapeIdentifiers($this->db->schema) . '.' . $this->db->escapeIdentifiers($table);
 
             // Drop default constraints
-            $fields = "'" . implode("','", (array) $field) . "'";
+            $fields = implode(',', $this->db->escape((array) $field));
 
             $sql = <<<SQL
                 SELECT name

diff --git a/user_guide_src/source/changelogs/v4.3.0.rst b/user_guide_src/source/changelogs/v4.3.0.rst
@@ -67,6 +67,7 @@ Others
 - Now ``spark routes`` command shows route names. See :ref:`URI Routing <routing-spark-routes>`.
 - Added new :ref:`entities-property-casting` class ``IntBoolCast`` for Entity.
 - Help information for a spark command can now be accessed using the ``--help`` option (e.g. ``php spark serve --help``)
+- SQLSRV now automatically drops ``DEFAULT`` constraint when using ``Forge::dropColumn()``.
 
 Changes
 *******