applied code review suggestion

codeigniter4 · Oct 24, 2023 · 23eb997 · 23eb997
1 parent 10815db
commit 23eb997
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/system/Commands/Generators/ModelGenerator.php b/system/Commands/Generators/ModelGenerator.php
@@ -101,9 +101,6 @@ protected function prepare(string $class): string
             $baseClass = $match[1];
         }
 
-        // Add or remove the DBGroup line based on the presence of the dbgroup option
-        $addDBGroupLine = is_string($dbGroup);
-
         $table  = is_string($table) ? $table : plural(strtolower($baseClass));
         $return = is_string($return) ? $return : 'array';
 
@@ -131,6 +128,6 @@ protected function prepare(string $class): string
             $return = "'{$return}'";
         }
 
-        return $this->parseTemplate($class, ['{dbGroup}', '{table}', '{return}'], [$dbGroup, $table, $return], compact('addDBGroupLine'));
+        return $this->parseTemplate($class, ['{dbGroup}', '{table}', '{return}'], [$dbGroup, $table, $return], compact('dbGroup'));
     }
 }
diff --git a/system/Commands/Generators/Views/model.tpl.php b/system/Commands/Generators/Views/model.tpl.php
@@ -6,7 +6,7 @@
 
 class {class} extends Model
 {
-<?php if ($addDBGroupLine): ?>
+<?php if (is_string($dbGroup)): ?>
     protected $DBGroup          = '{dbGroup}';
 <?php endif; ?>
     protected $table            = '{table}';