Merge pull request #8046 from kenjis/refactor-BaseModel-assert

[4.5] refactor: remove BaseModel assert()
codeigniter4 · Oct 18, 2023 · 232ddfa · 232ddfa
2 parents 7b1500c + dedb5fa
commit 232ddfa
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 7 deletions.
diff --git a/phpstan-baseline.php b/phpstan-baseline.php
@@ -66,11 +66,6 @@
 	'count' => 1,
 	'path' => __DIR__ . '/system/BaseModel.php',
 ];
-$ignoreErrors[] = [
-	'message' => '#^Only booleans are allowed in an if condition, int given\\.$#',
-	'count' => 1,
-	'path' => __DIR__ . '/system/BaseModel.php',
-];
 $ignoreErrors[] = [
 	'message' => '#^Strict comparison using \\!\\=\\= between mixed and null will always evaluate to true\\.$#',
 	'count' => 1,

diff --git a/system/BaseModel.php b/system/BaseModel.php
@@ -1640,8 +1640,6 @@ protected function objectToArray($data, bool $onlyChanged = true, bool $recursiv
     {
         $properties = $this->objectToRawArray($data, $onlyChanged, $recursive);
 
-        assert(is_array($properties));
-
         // Convert any Time instances to appropriate $dateFormat
         if ($properties !== []) {
             $properties = array_map(function ($value) {