Merge pull request #1138 from samsonasik/int-cast-rem

remove unneeded (int) casting as use int type hint or certainly an int
codeigniter4 · Aug 6, 2018 · 1f43e8c · 1f43e8c
2 parents 0f98889 + cc216b5
commit 1f43e8c
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/system/CodeIgniter.php b/system/CodeIgniter.php
@@ -552,7 +552,7 @@ public function displayCache($config)
 	 */
 	public static function cache(int $time)
 	{
-		self::$cacheTTL = (int) $time;
+		self::$cacheTTL = $time;
 	}
 
 	//--------------------------------------------------------------------

diff --git a/system/HTTP/URI.php b/system/HTTP/URI.php
@@ -633,7 +633,7 @@ public function setHost(string $str)
 	 *
 	 * @return $this
 	 */
-	public function setPort($port)
+	public function setPort(int $port = null)
 	{
 		if (is_null($port))
 		{
@@ -952,7 +952,7 @@ protected function applyParts($parts)
 			if ( ! is_null($parts['port']))
 			{
 				// Valid port numbers are enforced by earlier parse_url or setPort()
-				$port = (int) $parts['port'];
+				$port = $parts['port'];
 				$this->port = $port;
 			}
 		}

diff --git a/system/View/Filters.php b/system/View/Filters.php
@@ -222,7 +222,7 @@ public static function limit_words($value, int $limit = 100): string
 	 *
 	 * @return string
 	 */
-	public static function local_number($value, string $type='decimal', $precision=4, string $locale = null): string
+	public static function local_number($value, string $type='decimal', int $precision=4, string $locale = null): string
 	{
 		helper('number');
 
@@ -236,7 +236,7 @@ public static function local_number($value, string $type='decimal', $precision=4
 			'duration'   => \NumberFormatter::DURATION,
 		];
 
-		return format_number($value, (int)$precision, $locale, ['type' => $types[$type]]);
+		return format_number($value, $precision, $locale, ['type' => $types[$type]]);
 	}
 
 	//--------------------------------------------------------------------