Merge pull request #8155 from kenjis/refactor-redis-ttl

refactor: RedisHandler ttl() calls
codeigniter4 · Nov 6, 2023 · 1c33359 · 1c33359
2 parents a60c5b0 + 3a2cc73
commit 1c33359
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 6 deletions.
diff --git a/phpstan-baseline.php b/phpstan-baseline.php
@@ -3036,11 +3036,6 @@
 	'count' => 1,
 	'path' => __DIR__ . '/system/Session/Handlers/RedisHandler.php',
 ];
-$ignoreErrors[] = [
-	'message' => '#^Only booleans are allowed in a negated boolean, int given\\.$#',
-	'count' => 1,
-	'path' => __DIR__ . '/system/Session/Handlers/RedisHandler.php',
-];
 $ignoreErrors[] = [
 	'message' => '#^Accessing offset \'HTTP_X_REQUESTED_WITH\' directly on \\$_SERVER is discouraged\\.$#',
 	'count' => 2,

diff --git a/system/Cache/Handlers/RedisHandler.php b/system/Cache/Handlers/RedisHandler.php
@@ -245,6 +245,7 @@ public function getMetaData(string $key)
         if ($value !== null) {
             $time = Time::now()->getTimestamp();
             $ttl  = $this->redis->ttl(static::validateKey($key, $this->prefix));
+            assert(is_int($ttl));
 
             return [
                 'expire' => $ttl > 0 ? $time + $ttl : null,

diff --git a/system/Session/Handlers/RedisHandler.php b/system/Session/Handlers/RedisHandler.php
@@ -293,7 +293,10 @@ protected function lockSession(string $sessionID): bool
         $attempt = 0;
 
         do {
-            if (($ttl = $this->redis->ttl($lockKey)) > 0) {
+            $ttl = $this->redis->ttl($lockKey);
+            assert(is_int($ttl));
+
+            if ($ttl > 0) {
                 sleep(1);
 
                 continue;