Merge pull request #1679 from nowackipawel/patch-39

save_path - for memcached (Session.php) + sess_prefix (..Handler.php)
codeigniter4 · Jan 25, 2019 · 1c1bb68 · 1c1bb68
2 parents 415b805 + 3fd233e
commit 1c1bb68
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/system/Session/Handlers/MemcachedHandler.php b/system/Session/Handlers/MemcachedHandler.php
@@ -94,6 +94,11 @@ public function __construct(BaseConfig $config, string $ipAddress)
 		{
 			$this->keyPrefix .= $this->ipAddress . ':';
 		}
+
+		if(!empty($this->keyPrefix))
+		{
+			ini_set('memcached.sess_prefix', $this->keyPrefix);
+		}
 
 		$this->sessionExpiration = $config->sessionExpiration;
 	}
@@ -184,7 +189,7 @@ public function read($sessionID)
 			return $session_data;
 		}
 
-		return false;
+		return '';
 	}
 
 	//--------------------------------------------------------------------

diff --git a/system/Session/Session.php b/system/Session/Session.php
@@ -303,6 +303,11 @@ protected function configure()
 		{
 			ini_set('session.gc_maxlifetime', (int) $this->sessionExpiration);
 		}
+
+		if(!empty($this->sessionSavePath))
+		{
+			ini_set('session.save_path', $this->sessionSavePath);
+		}
 
 		// Security is king
 		ini_set('session.use_trans_sid', 0);