Merge pull request #6778 from kenjis/add-ResultInterface-getNumRows

fix: add missing ResultInterface::getNumRows()
codeigniter4 · Oct 28, 2022 · 1abb1f4 · 1abb1f4
2 parents 41ea704 + 8704c8d
commit 1abb1f4
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/system/Database/ResultInterface.php b/system/Database/ResultInterface.php
@@ -126,6 +126,11 @@ public function getNextRow(string $type = 'object');
      */
     public function getPreviousRow(string $type = 'object');
 
+    /**
+     * Returns number of rows in the result set.
+     */
+    public function getNumRows(): int;
+
     /**
      * Returns an unbuffered row and move the pointer to the next row.
      *

diff --git a/user_guide_src/source/changelogs/v4.3.0.rst b/user_guide_src/source/changelogs/v4.3.0.rst
@@ -62,6 +62,7 @@ Interface Changes
 - Now ``RequestInterface`` extends ``MessageInterface``.
 - Now ``ResponseInterface`` extends ``MessageInterface``.
 - Added missing ``ResponseInterface::getCSP()`` (and ``Response::getCSP()``), ``ResponseInterface::getReasonPhrase()`` and ``ResponseInterface::getCookieStore()`` methods.
+- Added missing ``CodeIgniter\Database\ResultInterface::getNumRows()`` method.
 - See also `Validation Changes`_.
 
 Method Signature Changes