REturn false from validation when no rules exist

codeigniter4 · Sep 23, 2017 · 0bda6ee · 0bda6ee
1 parent 94db0fe
commit 0bda6ee
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/system/Validation/Validation.php b/system/Validation/Validation.php
@@ -129,6 +129,13 @@ public function run(array $data = null, string $group = null): bool
 
 		$this->loadRuleGroup($group);
 
+		// If no rules exist, we return false to ensure
+		// the developer didn't forget to set the rules.
+		if (empty($this->rules))
+		{
+			return false;
+		}
+
 		// Run through each rule. If we have any field set for
 		// this rule, then we need to run them through!
 		foreach ($this->rules as $rField => $ruleString)

diff --git a/tests/system/Validation/ValidationTest.php b/tests/system/Validation/ValidationTest.php
@@ -55,11 +55,11 @@ public function testSetRulesStoresRules()
 
 	//--------------------------------------------------------------------
 
-	public function testRunReturnsTrueWithNothingToDo()
+	public function testRunReturnsFalseWithNothingToDo()
 	{
 		$this->validation->setRules([]);
 
-		$this->assertTrue($this->validation->run([]));
+		$this->assertFalse($this->validation->run([]));
 	}
 
 	//--------------------------------------------------------------------