migrate with 0-downtime #727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noam-codefresh
requested review from
danielm-codefresh,
pasha-codefresh and
daniel-codefresh
as code owners
noam-codefresh
commented
Dec 13, 2023
| @@ -115,16 +138,19 @@ func runHelmMigrate(ctx context.Context, opts *MigrateOptions) error { | |||
| return err | |||
| } | |||
|
|
|||
| opts.runtimeNamespace = *runtime.Metadata.Namespace | |||
There was a problem hiding this comment.
i decided to just put some values on the opts, and send them down into the funcs, instead of adding more and more parameters
noam-codefresh
commented
Dec 13, 2023
|
|
||
| destRepo, _, err := destCloneOpts.GetRepo(ctx) | ||
| log.G(ctx).Infof("Pushed changes to installation repo %q, sha: %s", opts.runtimeRepo, sha) | ||
| err = removeFromCluster(ctx, opts.helmReleaseName, *runtime.Metadata.Namespace, opts.kubeContext, srcCloneOpts, opts.kubeFactory) |
There was a problem hiding this comment.
moved removeFromCluster (autopilot uninstall) before destRepo persist
danielm-codefresh
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
improve migration process by having 0-downtime for all applications that might be deployed from git-sources
Why
enable smooth transition from cli to helm runtime
Notes