Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: disabled SQLi_BODY rule on waf for uploading image #343

Merged

Conversation

komtaki
Copy link
Contributor

@komtaki komtaki commented Feb 22, 2022

🎩 What? Why?

画像アップロード時に誤検知されることがあるので、WAFのルールでSQLi_BODYを無効化します。

staging, production反映済みです。

📌 Related Issues

📋 Subtasks

  • Add CHANGELOG upgrade notes, if required
  • If there's a new public field, add it to GraphQL API
  • Add documentation regarding the feature
  • Add/modify seeds
  • Add tests
  • Another subtask

@komtaki komtaki requested a review from ayuki-joto February 22, 2022 10:52
@ayuki-joto
Copy link
Collaborator

これ素直にoffにするしか対応方法ない感じですよね...

@ayuki-joto ayuki-joto merged commit dc9d321 into codeforjapan:develop Feb 28, 2022
@ayuki-joto ayuki-joto mentioned this pull request Mar 6, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wafで、一部の画像のuploadがSQLi_BODYのルールに引っ掛かってしまう
2 participants