Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix db:seed in docker #306

Merged
merged 2 commits into from
Nov 10, 2021
Merged

Fix db:seed in docker #306

merged 2 commits into from
Nov 10, 2021

Conversation

takahashim
Copy link
Collaborator

@takahashim takahashim commented Nov 8, 2021 •
edited
Loading

🎩 What? Why?

This patch is from docker/for-linux#1015 (comment)

DockerでFileUtilsのcopy_fileを使うと0バイトのファイルができることがある（！？）ようなので、それをtouchで回避するworkaroundを入れてみます。
touchでファイルがなければ作るだけなので、Docker以外でも特に問題はないはずです。

📌 Related Issues

📋 Subtasks

  • Add CHANGELOG upgrade notes, if required
  • If there's a new public field, add it to GraphQL API
  • Add documentation regarding the feature
  • Add/modify seeds
  • Add tests
  • Another subtask

@takahashim takahashim mentioned this pull request Nov 8, 2021
Closed
@ayuki-joto
Copy link
Collaborator

ayuki-joto commented Nov 8, 2021 •
edited
Loading

ありがとうございます！！！
かなり限られた条件下で再現する問題ですが解決しそうでよかったです！！

@ayuki-joto
Copy link
Collaborator

@komtaki
僕の環境では動作確認できましたが念のためご確認いただいていいでしょうか？

komtaki
komtaki approved these changes Nov 9, 2021
View reviewed changes
Copy link
Contributor

@komtaki komtaki left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

こんなバグがあるんですね。公式dockerで対応されるのが待ち遠しいです。:thinking:

私のローカルでも確認できました。対応ありがとうございます。

@ayuki-joto ayuki-joto merged commit ed9eddb into codeforjapan:develop Nov 10, 2021
@takahashim takahashim mentioned this pull request Nov 12, 2021
Closed
@takahashim takahashim deleted the fix-253 branch November 21, 2021 04:05
@ayuki-joto ayuki-joto mentioned this pull request Jan 17, 2022
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@komtaki komtaki komtaki approved these changes

@ayuki-joto ayuki-joto ayuki-joto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docke環境でseedが動かない
3 participants
@takahashim @ayuki-joto @komtaki