Optimize a query in Decidim::ResourceVersionsHelper.resource_version
#289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…idim/resource_versions_helper.rb
Use `select count(*) from versions ...` instead of `select versions.* from versions ...`
|
I made a PR to upstream to fix this issue. decidim/decidim#8393 |
takahashim
changed the title
Decidim::ResourceVersionsHelper.resource_version でのクエリを最適化するDecidim::ResourceVersionsHelper.resource_version
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
ディベートのコメント一覧画面において、
versionsテーブルに対する不要な（重い）クエリを発行しないようにするための修正です。ディベートのコメント一覧画面ではversionsテーブルは件数しか使用していないのですが、現状
SELECT "versions".* FROM "versions" WHERE ...というクエリを発行するようになっています。そのため、これをSELECT count(*) ...にするものです。ちなみに現状は上記クエリを発行した直後で
SELECT count(*) ...を再度発行するのですが、2回目以降はキャッシュが使われる（のでDBアクセスそのものが1回分省ける）ようでした。