refactor: apply lint

codeforjapan · Oct 15, 2022 · 50f3114 · 50f3114
1 parent 1d2f5e3
commit 50f3114
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/app/previewers/heic_previewer.rb b/app/previewers/heic_previewer.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class HeicPreviewer < ActiveStorage::Previewer
   CONTENT_TYPE = "image/heic"
 
@@ -7,7 +9,7 @@ def accept?(blob)
     end
 
     def minimagick_exists?
-      return @minimagick_exists unless @minimagick_exists.blank?
+      return @minimagick_exists if @minimagick_exists.present?
 
       @minimagick_exists = defined?(ImageProcessing::MiniMagick)
       Rails.logger.error "#{self.class} :: MiniMagick is not installed" unless @minimagick_exists
@@ -16,7 +18,7 @@ def minimagick_exists?
     end
   end
 
-  def preview(transformations)
+  def preview
     download_blob_to_tempfile do |input|
       io = ImageProcessing::MiniMagick.source(input).convert("png").call
       yield io: io, filename: "#{blob.filename.base}.png", content_type: "image/png"

diff --git a/config/initializers/active_storage.rb b/config/initializers/active_storage.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 Rails.application.configure do
   config.active_storage.previewers << HeicPreviewer
   config.active_storage.variable_content_types << "image/heic"

diff --git a/test/previewers/heic_previewer_test.rb b/test/previewers/heic_previewer_test.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "test_helper"
 
 class HeicPreviewerTest < ActiveSupport::TestCase
@@ -10,7 +12,7 @@ class HeicPreviewerTest < ActiveSupport::TestCase
 
     blob = create_file_blob(filename: "heic-image-file.heic", content_type: CONTENT_TYPE)
 
-    refute_nil blob
+    assert_not_nil blob
     assert HeicPreviewer.accept?(blob)
 
     HeicPreviewer.new(blob).preview({}) do |attachable|