Make private key path OS indendant

[sebjulliand]

Scenario

I use Code for i on several systems and I use VS Code settings synchronization so I my connection settings are shared across all my systems.

Since I may not be using the same OS and/or user name on these systems, the private key path set in the settings is different on all the systems, making it impossible to share that setting (the last path used will erase all the others because of VS Code synch).

Changes

This PR changes the connection private key path before it is stored to make it OS agnostic:

• If the path starts with the user's hoe directory path, this part of the path is replaced by ~
• The path is always stored with / as the path segment separator

When the private key path is displayed in the settings or retrieved to connect to an LPAR, it is transformed to a local path:

• ~ is replaced with the current user home directory
• / are converted back to \ when running on Windows

This is how it looks:

• In the settings:
  

• Displayed/used on Linux
  

• Displayed/used on Windows
  

This was tested on both Windows and Linux thanks to the settings synchronization. Each system used a different ed25519 private key. I created the connection from one system and I could connect from the other after the settings got synched.

A warning is displayed in the settings if the private key doesn't exist on the system.

How to test this PR

1. Set a private key to connect to a system
2. Check the user settings to see how it's stored
3. Connect to the system

Checklist

• have tested my change

[github-actions]

👋 A new build is available for this PR based on 22ba1f4.

• Download here.
• Read more about how to test

[worksofliam]

Seems like just one log that needs to be removed and then it's good to go.

[sebjulliand]

@worksofliam back at you!

[worksofliam]

Very good @sebjulliand! Merge away :)