Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced Terminal opening process #2389

Merged
merged 4 commits into from
Dec 2, 2024
Merged

Conversation

sebjulliand
Copy link
Collaborator

Changes

Resolves #2359

When Code for IBM i opens a new Terminal, the TERM environment variable is now set to xterm.
The Terminal opening process has been refactored and enhanced a bit to:

  • Add current directory as an optional property of the TerminalSettings type
  • Wait until the Terminal is actually ready to fire events before doing anything
  • Hide the initial commands sent to the terminal
  • Display a nice message when the terminal is ready
    image

How to test this PR

  1. Open a PASE terminal from the bottom status bar
  2. Open a PASE terminal by right-clicking on an IFS directory and select Open a Terminal here
  3. Open a 5250 terminal

Checklist

  • have tested my change

@sebjulliand sebjulliand added the enhancement New feature or request label Nov 29, 2024
@sebjulliand sebjulliand self-assigned this Nov 29, 2024
Copy link
Contributor

github-actions bot commented Nov 29, 2024

👋 A new build is available for this PR based on 8df5d99.

@worksofliam
Copy link
Contributor

I checked out the branch but when I open the terminal it just hangs. I will continue to debug tomorrow.

@sebjulliand
Copy link
Collaborator Author

Hopefully that happened with the built VSIX, because the build started after the third commit, that fixes the terminal hanging when opened. I double checked and I can open the terminal without issue with the branch checked out.
If is still doesn't show for you, it would mean the open event is never triggered for some reason and I'll start to freak out.

@sebjulliand
Copy link
Collaborator Author

@worksofliam scratch that, the Terminal output is weird...the string is not always the one expected. See below, the "end tag" is messed up (doone instead of done).
image

I'll try to foul-proof it.

@sebjulliand
Copy link
Collaborator Author

@worksofliam it should be OK now.

@worksofliam
Copy link
Contributor

@sebjulliand Look at that!

image

Gotta do one more test to confirm it works.

Copy link
Contributor

@worksofliam worksofliam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge whenever you're ready!

image

@sebjulliand
Copy link
Collaborator Author

Brilliant, thanks @worksofliam !

@sebjulliand sebjulliand merged commit 3e93d92 into master Dec 2, 2024
1 check passed
@sebjulliand sebjulliand deleted the terminal/openAndXterm branch December 2, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

set TERM to xterm
2 participants