-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhanced Terminal opening process #2389
Conversation
Signed-off-by: Seb Julliand <[email protected]>
Signed-off-by: Seb Julliand <[email protected]>
Signed-off-by: Seb Julliand <[email protected]>
👋 A new build is available for this PR based on 8df5d99. |
I checked out the branch but when I open the terminal it just hangs. I will continue to debug tomorrow. |
Hopefully that happened with the built VSIX, because the build started after the third commit, that fixes the terminal hanging when opened. I double checked and I can open the terminal without issue with the branch checked out. |
@worksofliam scratch that, the Terminal output is weird...the string is not always the one expected. See below, the "end tag" is messed up ( I'll try to foul-proof it. |
Signed-off-by: Seb Julliand <[email protected]>
@worksofliam it should be OK now. |
@sebjulliand Look at that! Gotta do one more test to confirm it works. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Brilliant, thanks @worksofliam ! |
Changes
Resolves #2359
When Code for IBM i opens a new Terminal, the TERM environment variable is now set to xterm.
The Terminal opening process has been refactored and enhanced a bit to:
TerminalSettings
typeHow to test this PR
Open a Terminal here
Checklist