Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement custom file picker functionality in CustomUI #2386

Merged
merged 3 commits into from
Dec 2, 2024
Merged

Implement custom file picker functionality in CustomUI #2386

merged 3 commits into from
Dec 2, 2024

Conversation

worksofliam
Copy link
Contributor

Introduce the native file picker feature that allows users to select files through a button in the CustomUI. This change enhances user interaction by enabling file selection and updating the corresponding field with the selected file's path.

@worksofliam worksofliam changed the title Implement file picker functionality in CustomUI Implement custom file picker functionality in CustomUI Nov 28, 2024
@worksofliam worksofliam linked an issue Nov 28, 2024 that may be closed by this pull request
Unable to connect with SSH certificate #2361
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 28, 2024 •
edited
Loading

👋 A new build is available for this PR based on 06c30a9.

@sebjulliand sebjulliand added the bug A confirmed issue when something isn't working as intended label Nov 29, 2024
sebjulliand
sebjulliand requested changes Nov 29, 2024
View reviewed changes
Copy link
Collaborator

@sebjulliand sebjulliand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice change; works like a charm!

I'd have one request: do you think you can bump the UI framework version and replace the vsc-select event by vsc-tree-select, like I did in #2342 ?

If so, we can kill two bird with one stone and delete #2342.

@worksofliam worksofliam self-assigned this Nov 29, 2024
@worksofliam
Copy link
Contributor Author

@sebjulliand I have done:

  1. Updated the package
  2. Copied over your additional changes
  3. Tested with the updated package and it's working as expected still.

sebjulliand
sebjulliand approved these changes Dec 2, 2024
View reviewed changes
Copy link
Collaborator

@sebjulliand sebjulliand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, very good change. Thanks mate!

@sebjulliand sebjulliand merged commit 27160a2 into master Dec 2, 2024
1 check passed
@sebjulliand sebjulliand deleted the fix/file_selector branch December 2, 2024 09:40
@sebjulliand sebjulliand mentioned this pull request Dec 2, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebjulliand sebjulliand sebjulliand approved these changes

Assignees

@worksofliam worksofliam

Labels
bug A confirmed issue when something isn't working as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to connect with SSH certificate
2 participants
@worksofliam @sebjulliand