-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend the base API to allow other extensions to add their own components. #2232
Conversation
…ents. Signed-off-by: worksofliam <[email protected]>
Signed-off-by: Seb Julliand <[email protected]>
Signed-off-by: Seb Julliand <[email protected]>
@worksofliam I tried to make the component's workflow as clear as possible for whoever would like to register a component. Question: would we want to keep track of which extension registers which component and be able to display a list of all the registered components (in the settings view, for example)? |
Signed-off-by: Seb Julliand <[email protected]>
@worksofliam give it a whirl 😊 |
Signed-off-by: Seb Julliand <[email protected]>
Signed-off-by: Seb Julliand <[email protected]>
src/components/component.ts
Outdated
export enum ComponentState { | ||
NotChecked = `NotChecked`, | ||
NotInstalled = `NotInstalled`, | ||
export const enum ComponentState { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we convert this to a type
so it's easier to export?
Signed-off-by: worksofliam <[email protected]>
@sebjulliand Okay, I think we need one final test each and then we're good! |
Working good for me - let's merge away! |
Changes
Adds brand new export to the base API which allows other extensions to add their own installable components.
Components are checked on connection to ensure they are installed on the OS.
How to test this PR
Examples:
Checklist
console.log
s I added