Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed IFS commands/methods crashing with paths with blanks #2221

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

sebjulliand
Copy link
Collaborator

Changes

Some commands/methods were not working if the IFS path they received contained blanks, namely:

  • Saving an IFS file whose CCSID was not Unicode (fixed iconv call)
  • Opening a terminal
  • Adding a new IFS shortcut

How to test this PR

  1. Create a folder with blanks in its name
  2. Add its path to the IFS browser
  3. Right-click and open a Terminal on it
  4. Create a file in it with CCSID 850
  5. Edit the file, make some changes, save it
  6. Reload VSCode (the file may be in memory)
  7. Open the file; changes must be kept

Checklist

  • have tested my change

Signed-off-by: Seb Julliand <[email protected]>
@sebjulliand sebjulliand added the bug A confirmed issue when something isn't working as intended label Aug 21, 2024
@sebjulliand sebjulliand self-assigned this Aug 21, 2024
@worksofliam worksofliam merged commit 1f5fcd7 into master Aug 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A confirmed issue when something isn't working as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants