Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes/deployment_working_directory #1703

Merged
merged 2 commits into from
Dec 12, 2023
Merged

Fixes/deployment_working_directory #1703

merged 2 commits into from
Dec 12, 2023

Conversation

worksofliam
Copy link
Contributor

@worksofliam worksofliam commented Dec 11, 2023 •
edited
Loading

Changes

  • Adds &WORKDIR for local actions, which is the deployment directory and is not the same as &HOME (as they can be different)
  • Fixes issue where remote working directory was being changes by deployment. It no longer does this and instead uses the deploy directory when running commands (and we added &WORKDIR)
  • Cleanup 'compare' deploy API to have seperation of delete login (this will require a type change in the API)

Checklist

  • have tested my change
  • updated relevant documentation
  • Remove any/all console.logs I added
  • eslint is not complaining
  • have added myself to the contributors' list in CONTRIBUTING.md
  • for feature PRs: PR only includes one feature enhancement.

@worksofliam worksofliam added the build Build will be available inside PR. label Dec 11, 2023
@worksofliam worksofliam added this to the 2.6.0 milestone Dec 11, 2023
@worksofliam worksofliam added the bug A confirmed issue when something isn't working as intended label Dec 11, 2023
@worksofliam worksofliam mentioned this pull request Dec 11, 2023
Merged
6 tasks
@worksofliam worksofliam linked an issue Dec 11, 2023 that may be closed by this pull request
Improve compare deployment method #1702
Closed
sebjulliand
sebjulliand approved these changes Dec 12, 2023
View reviewed changes
Copy link
Collaborator

@sebjulliand sebjulliand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; gave it another test round and it looks OK.
And I was here while you coded this 😅

Feel free to merge when you're OK with it.

@worksofliam worksofliam merged commit e3d624f into master Dec 12, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebjulliand sebjulliand sebjulliand approved these changes

Assignees
No one assigned
Labels
bug A confirmed issue when something isn't working as intended build Build will be available inside PR.
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.

Improve compare deployment method
2 participants
@worksofliam @sebjulliand