-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update webview-elements to 0.12.0 #1131
Conversation
Signed-off-by: Liam Allan <[email protected]>
Signed-off-by: Liam Allan <[email protected]>
Signed-off-by: Liam Allan <[email protected]>
Hi, I found a CSS margin issue in the settings-form variation of FormGroup and this affects your extension. I've fixed it in the 0.10.3 |
@worksofliam Maybe we should go to the newest release 0.11.0 of the toolkit? Doesn't seem to contain any changes with consequences for us - and with the can open... 😉 |
If you could wait a few more days I would add some improvements.
|
Signed-off-by: Liam Allan <[email protected]>
Signed-off-by: Liam Allan <[email protected]>
Signed-off-by: Liam Allan <[email protected]>
Signed-off-by: Liam Allan <[email protected]>
Signed-off-by: Liam Allan <[email protected]>
Signed-off-by: Liam Allan <[email protected]>
@bendera Thank you for the CSS fixes and the likes! @chrjorgensen I've cleaned up the code further and bumped webview-elements to 0.12.0. Are you able to give it another run through for me whenever you have a moment? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@worksofliam LGTM - I gave it a spin and went through the following, where there is UI:
- connection settings
- login settings
- actions
- custom variables
All looked good and I found no errors.
Signed-off-by: Liam Allan <[email protected]>
Signed-off-by: Liam Allan <[email protected]>
Fixed and tested again myself to be sure and it's all looking good. I am going to merge. Thank you @chrjorgensen for your review! And thank you @bendera for supporting us with your fast releases :) |
Changes
Updatse webview-elements to 0.12.0 and closes #1124.
It mostly works the same.
though the spacing isn't the same.Also see this issue regardingfile
CustomUI type: https://github.com/bendera/vscode-webview-elements/issues/47Would like these merged before this can be merged:
Checklist
console.log
s I added