Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update webview-elements to 0.12.0 #1131

Merged
merged 12 commits into from
Mar 23, 2023
Merged

Update webview-elements to 0.12.0 #1131

merged 12 commits into from
Mar 23, 2023

Conversation

worksofliam
Copy link
Contributor

@worksofliam worksofliam commented Mar 12, 2023

Changes

Updatse webview-elements to 0.12.0 and closes #1124.

It mostly works the same. though the spacing isn't the same.

Also see this issue regarding file CustomUI type: https://github.com/bendera/vscode-webview-elements/issues/47

Would like these merged before this can be merged:

Checklist

  • have tested my change
  • updated relevant documentation
  • Remove any/all console.logs I added
  • eslint is not complaining
  • have added myself to the contributors' list in CONTRIBUTING.md
  • for feature PRs: PR only includes one feature enhancement.

@bendera
Copy link

bendera commented Mar 14, 2023

Hi,

I found a CSS margin issue in the settings-form variation of FormGroup and this affects your extension. I've fixed it in the 0.10.3

@chrjorgensen
Copy link
Collaborator

@worksofliam Maybe we should go to the newest release 0.11.0 of the toolkit? Doesn't seem to contain any changes with consequences for us - and with the can open... 😉

@bendera
Copy link

bendera commented Mar 16, 2023

If you could wait a few more days I would add some improvements.

  • Until now the Textarea component had a fixed default width but if the cols attribute is set, the inner textarea element always will be wider or narrower than the component itself. I've already fixed this but I haven't published it yet.
  • I will customize the native, ugly, and gray browser button in the file input.

@bendera
Copy link

bendera commented Mar 17, 2023

@worksofliam worksofliam changed the title Update webview-elements to 0.10.1 Update webview-elements to 0.12.0 Mar 19, 2023
@worksofliam worksofliam marked this pull request as ready for review March 19, 2023 03:44
@worksofliam
Copy link
Contributor Author

@bendera Thank you for the CSS fixes and the likes!

@chrjorgensen I've cleaned up the code further and bumped webview-elements to 0.12.0.

Are you able to give it another run through for me whenever you have a moment? Thanks!

chrjorgensen
chrjorgensen previously approved these changes Mar 19, 2023
Copy link
Collaborator

@chrjorgensen chrjorgensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@worksofliam LGTM - I gave it a spin and went through the following, where there is UI:

  • connection settings
  • login settings
  • actions
  • custom variables

All looked good and I found no errors.

@worksofliam
Copy link
Contributor Author

Fixed and tested again myself to be sure and it's all looking good. I am going to merge.

Thank you @chrjorgensen for your review! And thank you @bendera for supporting us with your fast releases :)

@worksofliam worksofliam merged commit 6843039 into master Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update UI toolkit
3 participants