RunCommand API to support custom library list and current library
#1111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Liam Barry Allan <[email protected]>
This was
linked to
issues
Mar 3, 2023
Signed-off-by: Liam Allan <[email protected]>
sebjulliand
approved these changes
Mar 25, 2023
There was a problem hiding this comment.
A nice change, as always!
Just a question @worksofliam : shouldn't &LIBLC be removed from here after this change?
https://github.com/halcyon-tech/vscode-ibmi/blob/8ed23c64bf379734d04711fba10fa5cd97b250e8/src/webviews/actions/varinfo.js#L8
|
@sebjulliand Not quite! I know some people who use |
|
@sebjulliand I am going to merge tomorrow. Merging tonight for a new release :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
LIBLandCURLIBto be defined in.envCompileTools#runCommandAPI now allows for&LIBLand&CURLIBto determine which library list and current library should be used when runningilecommandsImplements #1094, kind of resolves #812
Checklist
console.logs I added