Use type for component state instead of enum

Signed-off-by: worksofliam <[email protected]>

src/components/component.ts

@@ -1,12 +1,6 @@
 import IBMi from "../api/IBMi";
 
-export const enum ComponentState {
-  NotChecked = `Not checked`,
-  NotInstalled = `Not installed`,
-  Installed = `Installed`,
-  NeedUpdate = `Need update`,
-  Error = `Error`,
-}
+export type ComponentState = `NotChecked` | `NotInstalled` | `Installed` | `NeedsUpdate` | `Error`;
 
 export type ComponentIdentification = {
   name: string
@@ -39,7 +33,7 @@ export type IBMiComponentType<T extends IBMiComponent> = new (c: IBMi) => T;
  * 
  */
 export abstract class IBMiComponent {
-  private state = ComponentState.NotChecked;
+  private state: ComponentState = `NotChecked`;
 
   constructor(protected readonly connection: IBMi) {
 
@@ -52,14 +46,14 @@ export abstract class IBMiComponent {
   async check() {
     try {
       this.state = await this.getRemoteState();
-      if (this.state !== ComponentState.Installed) {
+      if (this.state !== `Installed`) {
         this.state = await this.update();
       }
     }
     catch (error) {
       console.log(`Error occurred while checking component ${this.toString()}`);
       console.log(error);
-      this.state = ComponentState.Error;
+      this.state = `Error`;
     }
 
     return this;

src/components/copyToImport.ts

@@ -17,8 +17,8 @@ export class CopyToImport extends IBMiComponent {
     return { name: 'CopyToImport', version: 1 };
   }
 
-  protected getRemoteState() {
-    return ComponentState.Installed;
+  protected getRemoteState(): ComponentState {
+    return `Installed`;
   }
 
   protected update(): ComponentState | Promise<ComponentState> {

src/components/getMemberInfo.ts

@@ -22,13 +22,13 @@ export class GetMemberInfo extends IBMiComponent {
       }
     }
     if (this.installedVersion < this.currentVersion) {
-      return ComponentState.NeedUpdate;
+      return `NeedsUpdate`;
     }
 
-    return ComponentState.Installed;
+    return `Installed`;
   }
 
-  protected async update() {
+  protected async update(): Promise<ComponentState> {
     const config = this.connection.config!;
     return this.connection.withTempDirectory(async tempDir => {
       const tempSourcePath = posix.join(tempDir, `getMemberInfo.sql`);
@@ -40,9 +40,9 @@ export class GetMemberInfo extends IBMiComponent {
       });
 
       if (result.code) {
-        return ComponentState.Error;
+        return `Error`;
       } else {
-        return ComponentState.Installed;
+        return `Installed`;
       }
     });
   }

src/components/getNewLibl.ts

@@ -7,14 +7,14 @@ export class GetNewLibl extends IBMiComponent {
     return { name: 'GetNewLibl', version: 1 };
   }
 
-  protected async getRemoteState() {
-    return this.connection.remoteFeatures[`GETNEWLIBL.PGM`] ? ComponentState.Installed : ComponentState.NotInstalled;
+  protected async getRemoteState(): Promise<ComponentState> {
+    return this.connection.remoteFeatures[`GETNEWLIBL.PGM`] ? `Installed` : `NotInstalled`;
   }
 
-  protected update() {
+  protected update(): Promise<ComponentState> {
     const config = this.connection.config!
     const content = instance.getContent();
-    return this.connection.withTempDirectory(async tempDir => {
+    return this.connection.withTempDirectory(async (tempDir): Promise<ComponentState> => {
       const tempSourcePath = posix.join(tempDir, `getnewlibl.sql`);
 
       await content!.writeStreamfileRaw(tempSourcePath, getSource(config.tempLibrary));
@@ -25,9 +25,9 @@ export class GetNewLibl extends IBMiComponent {
       });
 
       if (!result.code) {
-        return ComponentState.Installed;
+        return `Installed`;
       } else {
-        return ComponentState.Error;
+        return `Error`;
       }
     });
   }

src/components/manager.ts

@@ -39,7 +39,7 @@ export class ComponentManager {
 
   get<T extends IBMiComponent>(type: IBMiComponentType<T>, ignoreState?: boolean): T | undefined {
     const component = this.registered.get(type);
-    if (component && (ignoreState || component.getState() === ComponentState.Installed)) {
+    if (component && (ignoreState || component.getState() === `Installed`)) {
       return component as T;
     }
   }