-
-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversion to Graph Database #407
Conversation
DMalone87
commented
Aug 14, 2024
•
edited
Loading
edited
- Done: Convert to graph database
- Done: Update requirements
- Done: Remove SQLAlchemy
- Done: Update API to support db changes
- Done: Complete the data model conversion
- Done: Update tests to use the new DB
- Pass: Add database migration
- This will be handled in a future update.
- Convert to graph-based data model - Update requirements - Todo: Update API to support db changes - Todo: Complete the data model conversion - Todo: remove SQLAlchemy
Convert routes to use neomodel instead of SQLAlchemy
- Update docker-compose.yml to use the new neo4j container - Make additional corrections to the db models Additionally: Change env variable w/PDT to NPDI Our env vars will be changing anyway, so we might as well make this change now.
Most recent update finally has the Graph DB image replacing the PGSQL one. I'm using version 5.23-community |
- Add suffix to officer names - Add type and subtype to allegations - Add record ID to allegation and complaint - Allow for multiple agencies with the same name
Implement hidden fields Implement serialization of Node properties - Note: This is a WIP
- Get all partners - Get partner by ID - Create partner
- Get officer by ID - Get all officers - Create officer Fix error in officer model Add enum property for Partner MemberRole
- officers - agencies - partners Fix temporary pydantic schema for agencies
With the most recent update, the API works for most endpoints. Core CRUD functions are there. I'll most likely move on to getting the testing and migration infrastructure settled and handle the rest of the API function in a future PR. There will be some big changes coming to the API to bring it in line with the new API spec, so it's best to handle that at all at once. |
Update `test_register` and auth `resgister` route
Update reqs
Note: Leaving out the invitation and joining tests for now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few code style failures in test- will prevent this from being deployed. Though without db migration that may not matter.
|
||
- name: Types | ||
if: always() | ||
run: npm run check-types |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why remove frontend tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The front end is going to change significantly pretty soon so I didn't think it was that big of a priority.
That and I didn't really understand the test that was failing at the time. It was something to do with the registration page... The page runs and completes registration successfully though.
Added full address to Units Added Hispanic/Latino to ethnicity
relationships