Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ryan/epic2/userstory6 #318

Merged
merged 5 commits into from
Jan 20, 2024
Merged

Ryan/epic2/userstory6 #318

merged 5 commits into from
Jan 20, 2024

Conversation

@DMalone87
Copy link
Collaborator

So, the test passes fine, but I'm getting an error when I try to run Create on Postman. I think this is a preexisting error though so not your fault. It seems to be trying to reuse the Partner ID "1" which is probably why it doesn't fail the test and why I missed it earlier.

You may run into issues when trying to build on the API. But having something requesting against it will make the troubleshooting faster so I'm inclined to push this through. I'll leave it up to you all if you want to press ahead.

DMalone87
DMalone87 previously approved these changes Jan 20, 2024
Copy link
Collaborator

@DMalone87 DMalone87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with some reservation.

Corrects and issue where the SQLAlchemy Autoincrement
collides with already used IDs.
@DMalone87 DMalone87 merged commit e99bcaa into main Jan 20, 2024
3 checks passed
@DMalone87 DMalone87 deleted the ryan/epic2/userstory6 branch January 20, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants