-
-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Officer Search UI Mobile Responsiveness #317
Merged
DMalone87
merged 11 commits into
codeforboston:main
from
joshua-rdrgz:josh/officer-ui-mobile
Jan 20, 2024
Merged
Officer Search UI Mobile Responsiveness #317
DMalone87
merged 11 commits into
codeforboston:main
from
joshua-rdrgz:josh/officer-ui-mobile
Jan 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adjust HTML structure and CSS media queries add `nav.module.css` for organization
bring in react-tooltip dependency for managing tooltip positioning
shorten "allegations" column header text when on smaller screens remove "save" column from table
update snapshot for different tooltip implementation update snapshot for burger menu on mobile instead of ellipses
DMalone87
previously approved these changes
Jan 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Went ahead and fixed the merge conflicts, I used Abel's mock data strategy instead of the hardcoded values 👍🏽 |
Thanks! Merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains all the updates to make the officer search page mobile responsive. Happy to make any other changes if needed. Here's a quick rundown of all the changes:
Major adjustments made:
<Map />
and<BubbleChart />
components on mobile, leaving just the tableMinor adjustments made:
Screenshots: