-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev add audio #19
Open
sashamaryl
wants to merge
67
commits into
codeforboston:master
Choose a base branch
from
sashamaryl:dev-add-audio
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Dev add audio #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes are mostly for 4/24 demonstration and including a very messy way to 'disable' certain videos (videos do not lead to youtube player when clicked, and only specific videos are allowed).
This includes creating a smaller (less pixels) version of the App Landing page (original picture would not show up on the small phone screen) and slighly changing the logic used to hide the remenant (setting opacity to 0 seemed to only dim but not completely hide the remnant icon).
Save it as metadata WIP
This will need revisiting, but getFontScale() did not work as expected.
Very preliminary version of nav bar, does not have functionality for contextual help or remnant icon logic (ie. remnant icon appearing after viewing 2 videos).
- videos are now within the objectPages object
icons in the nav bar are no longer 'Button' components). The YouTube API link is not hard coded.
Remnants audio updates & return-to-menu after play
Keys of <Section> should match the names of the screens defined in TabNav, currently: screen section ------ ------- Chooser --> Home (Objects) RemnantChooser --> Remnants About --> Resources
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added audio assets which were missing before