Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift 6 #189

Draft
wants to merge 3 commits into
base: xcode16
Choose a base branch
from
Draft

Swift 6 #189

wants to merge 3 commits into from

Conversation

banjun
Copy link
Member

@banjun banjun commented Sep 28, 2024

migrate all targets to Swift 6, except pods

banjun-Air-M3:FlickSKK% git grep SWIFT_VERSION
FlickSKK.xcodeproj/project.pbxproj:                             SWIFT_VERSION = 6.0;
FlickSKK.xcodeproj/project.pbxproj:                             SWIFT_VERSION = 6.0;
FlickSKK.xcodeproj/project.pbxproj:                             SWIFT_VERSION = 6.0;
FlickSKK.xcodeproj/project.pbxproj:                             SWIFT_VERSION = 6.0;
FlickSKK.xcodeproj/project.pbxproj:                             SWIFT_VERSION = 6.0;
FlickSKK.xcodeproj/project.pbxproj:                             SWIFT_VERSION = 6.0;
FlickSKK.xcodeproj/project.pbxproj:                             SWIFT_VERSION = 6.0;
FlickSKK.xcodeproj/project.pbxproj:                             SWIFT_VERSION = 6.0;
FlickSKK.xcodeproj/project.pbxproj:                             SWIFT_VERSION = 6.0;
FlickSKK.xcodeproj/project.pbxproj:                             SWIFT_VERSION = 6.0;
Podfile:      c.build_settings['SWIFT_VERSION'] = '5.0' if %w[NorthLayout FootlessParser].include?(t.name)

health check

git grep '@unchecked'
git grep '@preconcurrency'
git grep 'assumeIsolated'
git grep 'nonisolated(unsafe)'

FlickSKKTests/DictionaryEngineSpec.swift:        MainActor.assumeIsolated {
FlickSKKTests/KeyHandlerDirectInputSpec.swift:        MainActor.assumeIsolated {
FlickSKKTests/KeyHandlerKanaComposeSpec.swift:        MainActor.assumeIsolated {
FlickSKKTests/KeyHandlerKanjiComposeSpec.swift:        MainActor.assumeIsolated {
FlickSKKTests/KeyHandlerWordRegisterWithDirectInputSpec.swift:        MainActor.assumeIsolated {
FlickSKKTests/KeyHandlerWordRegisterWithKanaComposeSpec.swift:        MainActor.assumeIsolated {
FlickSKKTests/SKKDictionarySpec.swift:        MainActor.assumeIsolated {
FlickSKKTests/SKKEngineSpec.swift:        MainActor.assumeIsolated {
FlickSKKTests/TextEngineSpec.swift:        MainActor.assumeIsolated {
Common/AsyncLoader.swift:    nonisolated(unsafe) var initialized = false
Common/DictionaryCache.swift:private nonisolated(unsafe) var kDicitonary : SKKLocalDictionaryFile?
Common/DictionaryCache.swift:private nonisolated(unsafe) var kCache : [URL:(Date, Any)] = [:]
Common/DictionarySettings.swift:        nonisolated(unsafe) static var bundle : Bundle?
Common/SKKDictionary.swift:    nonisolated(unsafe) fileprivate var dictionaries : [ SKKDictionaryFile ] = []
Common/SKKDictionary.swift:    nonisolated(unsafe) fileprivate var dynamicDictionaries : [ SKKUserDictionaryFile ] = []
Common/SKKDictionary.swift:    nonisolated(unsafe) fileprivate var userDictionary : SKKUserDictionaryFile?
Common/SKKDictionary.swift:    nonisolated(unsafe) fileprivate var learnDictionary : SKKUserDictionaryFile?
Common/SKKDictionary.swift:    nonisolated(unsafe) fileprivate var partialDictionary : SKKUserDictionaryFile?
Common/SKKDictionary.swift:    @objc nonisolated(unsafe) dynamic var isWaitingForLoad : Bool = false
FlickSKK/DownloadDictionary.swift:        nonisolated(unsafe) var observation: NSKeyValueObservation?

@banjun
Copy link
Member Author

banjun commented Oct 22, 2024

TestFlight Public Link
https://testflight.apple.com/join/ebdqQooj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant