Remove bg-black #2022

rohitpaulk · 2024-07-26T18:01:14Z

dark mode for course page
Add course sidebar dark mode
header navigation controls
more main section changes
more changes
more leaderboard changes
ts-ify
basic instructions card styling
repo setup card
Add dark mode preference and update course release status in start-course test
lint fix
Add gray versions
change color palette to gray

Summary by CodeRabbit

Visual Enhancements
- Updated background colors for various components to improve aesthetics and readability in dark mode.
- Adjusted text colors to enhance contrast and user experience across the application.
New Color Configuration
- Expanded the gray color palette to include a new customized shade (gray-925), enriching the design options available for dark mode styling.

coderabbitai · 2024-07-26T18:01:32Z

Walkthrough

This update enhances the visual experience of the application by refining color schemes, particularly in dark mode. Background and text colors have been adjusted to lighter shades for improved contrast and readability. These enhancements aim to create a more aesthetically cohesive interface while ensuring all components maintain their intended functionality.

Changes

Files	Change Summary
`app/components/course-card.hbs` `app/components/header.hbs` `app/components/tracks-page/track-card.hbs` `app/templates/settings.hbs`	Modified background and text color classes to lighter shades for better aesthetics and visibility in dark mode.
`app/components/footer.hbs`	Updated background and text color classes for improved visual presentation in the footer.
`app/components/settings/form-section.hbs` `app/components/settings/profile-page/about-section.hbs` `app/components/settings/profile-page/anonymous-mode-section.hbs` `app/components/settings/profile-page/avatar-section.hbs` `app/components/settings/profile-page/username-section.hbs`	Adjusted text color classes to enhance visual consistency across various sections.
`tailwind.config.js`	Enhanced gray color palette by adding a new `925` shade while preserving existing colors.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant App
    participant Components

    User->>App: Enable Dark Mode
    App->>Components: Adjust Background Colors
    Components-->>App: Confirm Styling Updates
    App-->>User: Display Updated UI

Poem

🐇 The colors dance, a subtle sway,
In shades of gray, they find their way.
From dark to light, a joyous blend,
A prettier scene around the bend.
Hopping through code with glee and cheer,
A vibrant world for all to share! 🌙✨

github-actions · 2024-07-26T18:04:47Z

Test Results

1 files ±0 1 suites ±0 6m 15s ⏱️ -19s
552 tests ±0 517 ✅ ±0 35 💤 ±0 0 ❌ ±0
567 runs ±0 532 ✅ ±0 35 💤 ±0 0 ❌ ±0

Results for commit 56eaa9a. ± Comparison against base commit d09fd5d.

♻️ This comment has been updated with latest results.

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between d09fd5d and 913f8aa.

Files selected for processing (26)

app/components/contest-page/how-it-works-card.hbs (1 hunks)
app/components/contest-page/leaderboard-card.hbs (1 hunks)
app/components/contest-page/prize-details-card.hbs (1 hunks)
app/components/course-card.hbs (1 hunks)
app/components/course-page/instructions-card.hbs (1 hunks)
app/components/course-page/sidebar.hbs (1 hunks)
app/components/course-page/test-results-bar.hbs (1 hunks)
app/components/course-page/test-results-bar/autofix-section/autofix-result.hbs (1 hunks)
app/components/course-page/test-results-bar/bottom-section.hbs (1 hunks)
app/components/file-contents-card.hbs (1 hunks)
app/components/footer.hbs (1 hunks)
app/components/header.hbs (2 hunks)
app/components/modal-body.hbs (1 hunks)
app/components/pill.ts (1 hunks)
app/components/settings/profile-page/about-section.hbs (1 hunks)
app/components/tertiary-button.hbs (1 hunks)
app/components/tertiary-link-button.hbs (1 hunks)
app/components/toggle.hbs (1 hunks)
app/components/tracks-page/track-card.hbs (2 hunks)
app/templates/application.hbs (1 hunks)
app/templates/badges.hbs (1 hunks)
app/templates/contest.hbs (1 hunks)
app/templates/course.hbs (3 hunks)
app/templates/demo.hbs (1 hunks)
app/templates/settings.hbs (1 hunks)
tailwind.config.js (1 hunks)

Files skipped from review due to trivial changes (23)

app/components/contest-page/how-it-works-card.hbs
app/components/contest-page/leaderboard-card.hbs
app/components/contest-page/prize-details-card.hbs
app/components/course-card.hbs
app/components/course-page/instructions-card.hbs
app/components/course-page/sidebar.hbs
app/components/course-page/test-results-bar.hbs
app/components/course-page/test-results-bar/autofix-section/autofix-result.hbs
app/components/course-page/test-results-bar/bottom-section.hbs
app/components/file-contents-card.hbs
app/components/footer.hbs
app/components/header.hbs
app/components/modal-body.hbs
app/components/pill.ts
app/components/settings/profile-page/about-section.hbs
app/components/tertiary-button.hbs
app/components/toggle.hbs
app/components/tracks-page/track-card.hbs
app/templates/badges.hbs
app/templates/contest.hbs
app/templates/course.hbs
app/templates/demo.hbs
app/templates/settings.hbs

Additional context used

Learnings (1)

app/components/tertiary-link-button.hbs (1)

Learnt from: VasylMarchuk
PR: codecrafters-io/frontend#1774
File: app/components/tertiary-link-button.hbs:8-8
Timestamp: 2024-05-26T17:08:30.227Z
Learning: `hover:bg-gray-50` is intentionally not set for Dark Mode and is explicitly listed for `light:` mode in the `app/components/tertiary-link-button.hbs` file to align with specific design choices.

Additional comments not posted (3)

app/templates/application.hbs (1)

5-5: LGTM! Improved dark mode background color.

The change from bg-black to bg-gray-950 enhances the visual distinction in dark mode, potentially improving readability and aesthetics.

app/components/tertiary-link-button.hbs (1)

9-9: LGTM! Consistent dark mode background color.

The change from dark:bg-black to dark:bg-gray-950 aligns with the design choice to use a deeper gray in dark mode, enhancing UI consistency and potentially improving readability.

tailwind.config.js (1)

33-36: LGTM! Enhanced gray color palette.

The change enhances the gray color palette by merging the existing colors.gray with a new shade 925, providing more nuanced design choices.

codecov · 2024-07-26T18:05:21Z

Bundle Report

Changes will decrease total bundle size by 1.72kB ⬇️

Bundle name	Size	Change
client-array-push	35.12MB	1.72kB ⬇️

codecov · 2024-07-26T18:07:31Z

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files

📢 Thoughts on this report? Let us know!

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 913f8aa and 92681b0.

Files selected for processing (6)

app/components/course-card.hbs (1 hunks)
app/components/header.hbs (2 hunks)
app/components/tracks-page/track-card.hbs (2 hunks)
app/templates/catalog.hbs (2 hunks)
app/templates/settings.hbs (1 hunks)
tailwind.config.js (2 hunks)

Files skipped from review due to trivial changes (3)

app/components/header.hbs
app/components/tracks-page/track-card.hbs
app/templates/catalog.hbs

Files skipped from review as they are similar to previous changes (3)

app/components/course-card.hbs
app/templates/settings.hbs
tailwind.config.js

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 92681b0 and 02f1930.

Files selected for processing (1)

app/components/footer.hbs (2 hunks)

Files skipped from review as they are similar to previous changes (1)

app/components/footer.hbs

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 02f1930 and 2a353e4.

Files selected for processing (5)

app/components/settings/form-section.hbs (1 hunks)
app/components/settings/profile-page/about-section.hbs (2 hunks)
app/components/settings/profile-page/anonymous-mode-section.hbs (2 hunks)
app/components/settings/profile-page/avatar-section.hbs (1 hunks)
app/components/settings/profile-page/username-section.hbs (1 hunks)

Files skipped from review due to trivial changes (4)

app/components/settings/form-section.hbs
app/components/settings/profile-page/anonymous-mode-section.hbs
app/components/settings/profile-page/avatar-section.hbs
app/components/settings/profile-page/username-section.hbs

Files skipped from review as they are similar to previous changes (1)

app/components/settings/profile-page/about-section.hbs

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 2a353e4 and 56eaa9a.

Files selected for processing (2)

app/components/course-card.hbs (2 hunks)
app/components/tracks-page/track-card.hbs (2 hunks)

Files skipped from review due to trivial changes (1)

app/components/tracks-page/track-card.hbs

Files skipped from review as they are similar to previous changes (1)

app/components/course-card.hbs

rohitpaulk added 2 commits July 26, 2024 18:51

Add gray versions

2c00f34

change color palette to gray

913f8aa

vercel bot deployed to Preview – frontend July 26, 2024 18:05 View deployment

vercel bot deployed to Preview – frontend-stg July 26, 2024 18:05 View deployment

coderabbitai bot reviewed Jul 26, 2024

View reviewed changes

add border alpha-700

92681b0

rohitpaulk changed the title ~~course dark mode~~ Remove bg-black Jul 26, 2024

vercel bot deployed to Preview – frontend July 26, 2024 18:26 View deployment

fix footer border

02f1930

coderabbitai bot reviewed Jul 26, 2024

View reviewed changes

vercel bot deployed to Preview – frontend July 26, 2024 18:31 View deployment

rohitpaulk added 2 commits July 26, 2024 19:31

update text colors

2a353e4

clearer text

56eaa9a

coderabbitai bot reviewed Jul 26, 2024

View reviewed changes

vercel bot deployed to Preview – frontend July 26, 2024 18:38 View deployment

rohitpaulk merged commit c237ed4 into main Jul 26, 2024
4 of 5 checks passed

rohitpaulk deleted the course-dark-mode branch July 26, 2024 18:39

vercel bot deployed to Preview – frontend-stg July 26, 2024 18:39 View deployment

coderabbitai bot mentioned this pull request Sep 28, 2024

More consistency for dark mode colors #2268

Merged

coderabbitai bot mentioned this pull request Oct 18, 2024

Clearer handling of expandable list steps #2333

Merged

coderabbitai bot mentioned this pull request Nov 23, 2024

mellow grays #2424

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove bg-black #2022

Remove bg-black #2022

rohitpaulk commented Jul 26, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jul 26, 2024 •

edited

Loading

github-actions bot commented Jul 26, 2024 •

edited

Loading

coderabbitai bot left a comment

codecov bot commented Jul 26, 2024 •

edited

Loading

codecov bot commented Jul 26, 2024

coderabbitai bot left a comment

coderabbitai bot left a comment

coderabbitai bot left a comment

coderabbitai bot left a comment

Remove bg-black #2022

Remove bg-black #2022

Conversation

rohitpaulk commented Jul 26, 2024 • edited by coderabbitai bot Loading

Summary by CodeRabbit

coderabbitai bot commented Jul 26, 2024 • edited Loading

Walkthrough

Changes

Sequence Diagram(s)

Poem

github-actions bot commented Jul 26, 2024 • edited Loading

Test Results

coderabbitai bot left a comment

Choose a reason for hiding this comment

codecov bot commented Jul 26, 2024 • edited Loading

Bundle Report

codecov bot commented Jul 26, 2024

Codecov Report

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

rohitpaulk commented Jul 26, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jul 26, 2024 •

edited

Loading

github-actions bot commented Jul 26, 2024 •

edited

Loading

codecov bot commented Jul 26, 2024 •

edited

Loading