Properly check for created coverage files #838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An empty `ReportFile` is boolean-coerced to `False`, so we always need to explicitly compare it to `None`. This primarily fixes the `JetBrainsXML` parser always emitting empty `Report`s. Also fixes cobertura failing on empty filenames, and other smaller fixes.
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #838 +/- ##
==========================================
+ Coverage 98.02% 98.04% +0.02%
==========================================
Files 442 443 +1
Lines 36026 36054 +28
==========================================
+ Hits 35313 35350 +37
+ Misses 713 704 -9
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #838 +/- ##
==========================================
+ Coverage 98.02% 98.04% +0.02%
==========================================
Files 442 443 +1
Lines 36026 36054 +28
==========================================
+ Hits 35313 35350 +37
+ Misses 713 704 -9
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #838 +/- ##
==========================================
+ Coverage 98.02% 98.04% +0.02%
==========================================
Files 442 443 +1
Lines 36026 36054 +28
==========================================
+ Hits 35313 35350 +37
+ Misses 713 704 -9
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #838 +/- ##
==========================================
+ Coverage 98.02% 98.04% +0.02%
==========================================
Files 442 443 +1
Lines 36026 36054 +28
==========================================
+ Hits 35313 35350 +37
+ Misses 713 704 -9
Flags with carried forward coverage won't be shown. Click here to find out more.
|
giovanni-guidini
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An empty
ReportFileis boolean-coerced toFalse, so we always need to explicitly compare it toNone.This primarily fixes the
JetBrainsXMLparser always emitting emptyReports. Also fixes cobertura failing on empty filenames, and other smaller fixes.Fixes codecov/feedback#532
Fixes WORKER-P9A