Refactor timeseries service to dedupe code #837
Conversation
There was a bunch of duplication and large methods. This refactoring reduces the duplication and hopefully makes things more readable and traceable.
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #837 +/- ##
=======================================
Coverage 98.02% 98.02%
=======================================
Files 442 442
Lines 36026 36035 +9
=======================================
+ Hits 35313 35322 +9
Misses 713 713
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #837 +/- ##
=======================================
Coverage 98.02% 98.02%
=======================================
Files 442 442
Lines 36026 36035 +9
=======================================
+ Hits 35313 35322 +9
Misses 713 713
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #837 +/- ##
=======================================
Coverage 98.02% 98.02%
=======================================
Files 442 442
Lines 36026 36035 +9
=======================================
+ Hits 35313 35322 +9
Misses 713 713
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #837 +/- ##
=======================================
Coverage 98.02% 98.02%
=======================================
Files 442 442
Lines 36026 36035 +9
=======================================
+ Hits 35313 35322 +9
Misses 713 713
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a bunch of duplication and large methods. This refactoring reduces the duplication and standardized measurement creation. Also, makes the giant method easier to follow, hopefully.
No functionality had been changed.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.