-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only show VCR logs on errors #836
Conversation
These logs were getting really noisy when testing locally. Removing unnecessary logs should make it more manageable to debug. If someone wants the full log, they can override the log levels.
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #836 +/- ##
=======================================
Coverage 98.02% 98.02%
=======================================
Files 442 442
Lines 36033 36036 +3
=======================================
+ Hits 35320 35323 +3
Misses 713 713
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #836 +/- ##
=======================================
Coverage 98.02% 98.02%
=======================================
Files 442 442
Lines 36033 36036 +3
=======================================
+ Hits 35320 35323 +3
Misses 713 713
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #836 +/- ##
=======================================
Coverage 98.02% 98.02%
=======================================
Files 442 442
Lines 36033 36036 +3
=======================================
+ Hits 35320 35323 +3
Misses 713 713
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #836 +/- ##
=======================================
Coverage 98.02% 98.02%
=======================================
Files 442 442
Lines 36033 36036 +3
=======================================
+ Hits 35320 35323 +3
Misses 713 713
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️ these were annoying me quite a bit :-D
These logs were getting really noisy when testing locally (especially when running with verbose mode
-vv
). Removing unnecessary logs should make it more manageable to debug, especially since the VCR logs aren't super useful. If someone wants the full log, they can remove this or override manually.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.