Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Tweaks to send email task #833

Merged
merged 2 commits into from
Oct 29, 2024
Merged

Conversation

spalmurray-codecov
Copy link
Contributor

@spalmurray-codecov spalmurray-codecov commented Oct 29, 2024

Updates the send email task to

  1. take a to-address instead of an owner and
  2. make from-address optional, pulling from config if not set explicitly in the call.

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.02%. Comparing base (bcb07ef) to head (a161b7b).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #833      +/-   ##
==========================================
- Coverage   98.03%   98.02%   -0.01%     
==========================================
  Files         441      441              
  Lines       36095    36087       -8     
==========================================
- Hits        35384    35376       -8     
  Misses        711      711              
Flag Coverage Δ
integration 98.02% <100.00%> (-0.01%) ⬇️
unit 98.02% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.92% <100.00%> (-0.01%) ⬇️
OutsideTasks 98.02% <ø> (ø)
Files with missing lines Coverage Δ
tasks/send_email.py 100.00% <100.00%> (ø)
tasks/tests/integration/test_send_email_task.py 100.00% <ø> (ø)
tasks/tests/unit/test_send_email_task.py 100.00% <100.00%> (ø)

@codecov-notifications
Copy link

codecov-notifications bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #833      +/-   ##
==========================================
- Coverage   98.03%   98.02%   -0.01%     
==========================================
  Files         441      441              
  Lines       36095    36087       -8     
==========================================
- Hits        35384    35376       -8     
  Misses        711      711              
Flag Coverage Δ
integration 98.02% <100.00%> (-0.01%) ⬇️
unit 98.02% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.92% <100.00%> (-0.01%) ⬇️
OutsideTasks 98.02% <ø> (ø)
Files with missing lines Coverage Δ
tasks/send_email.py 100.00% <100.00%> (ø)
tasks/tests/integration/test_send_email_task.py 100.00% <ø> (ø)
tasks/tests/unit/test_send_email_task.py 100.00% <100.00%> (ø)

@codecov-qa
Copy link

codecov-qa bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.02%. Comparing base (bcb07ef) to head (a161b7b).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #833      +/-   ##
==========================================
- Coverage   98.03%   98.02%   -0.01%     
==========================================
  Files         441      441              
  Lines       36095    36087       -8     
==========================================
- Hits        35384    35376       -8     
  Misses        711      711              
Flag Coverage Δ
integration 98.02% <100.00%> (-0.01%) ⬇️
unit 98.02% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.92% <100.00%> (-0.01%) ⬇️
OutsideTasks 98.02% <ø> (ø)
Files with missing lines Coverage Δ
tasks/send_email.py 100.00% <100.00%> (ø)
tasks/tests/integration/test_send_email_task.py 100.00% <ø> (ø)
tasks/tests/unit/test_send_email_task.py 100.00% <100.00%> (ø)

Copy link

codecov-public-qa bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.02%. Comparing base (bcb07ef) to head (a161b7b).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #833      +/-   ##
==========================================
- Coverage   98.03%   98.02%   -0.01%     
==========================================
  Files         441      441              
  Lines       36095    36087       -8     
==========================================
- Hits        35384    35376       -8     
  Misses        711      711              
Flag Coverage Δ
integration 98.02% <100.00%> (-0.01%) ⬇️
unit 98.02% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.92% <100.00%> (-0.01%) ⬇️
OutsideTasks 98.02% <ø> (ø)
Files Coverage Δ
tasks/send_email.py 100.00% <100.00%> (ø)
tasks/tests/integration/test_send_email_task.py 100.00% <ø> (ø)
tasks/tests/unit/test_send_email_task.py 100.00% <100.00%> (ø)

@spalmurray-codecov spalmurray-codecov marked this pull request as ready for review October 29, 2024 19:21
@spalmurray-codecov spalmurray-codecov added this pull request to the merge queue Oct 29, 2024
Merged via the queue into main with commit 9c74b4e Oct 29, 2024
26 of 27 checks passed
@spalmurray-codecov spalmurray-codecov deleted the spalmurray/send-email-tweaks branch October 29, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants