-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix leaky usage of time machine #832
Conversation
This was leaking into other tests (other tests were using the wrong times)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe sentry was using freezegun
at some point, not sure if they migrated away from that, or to that, which provides a decorator for a function. Might be another alternative, but either is fine.
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #832 +/- ##
==========================================
- Coverage 98.03% 98.03% -0.01%
==========================================
Files 442 442
Lines 36112 36104 -8
==========================================
- Hits 35401 35393 -8
Misses 711 711
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #832 +/- ##
==========================================
- Coverage 98.03% 98.03% -0.01%
==========================================
Files 442 442
Lines 36112 36104 -8
==========================================
- Hits 35401 35393 -8
Misses 711 711
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #832 +/- ##
==========================================
- Coverage 98.03% 98.03% -0.01%
==========================================
Files 442 442
Lines 36112 36104 -8
==========================================
- Hits 35401 35393 -8
Misses 711 711
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #832 +/- ##
==========================================
- Coverage 98.03% 98.03% -0.01%
==========================================
Files 442 442
Lines 36112 36104 -8
==========================================
- Hits 35401 35393 -8
Misses 711 711
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This was leaking into other tests (other tests were using the wrong times).
Pulled this out from #729
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.