Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix leaky usage of time machine #832

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Conversation

michelletran-codecov
Copy link
Contributor

This was leaking into other tests (other tests were using the wrong times).

Pulled this out from #729

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

This was leaking into other tests (other tests were using the wrong times)
@michelletran-codecov michelletran-codecov requested a review from a team October 29, 2024 15:45
Copy link
Contributor

@Swatinem Swatinem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe sentry was using freezegun at some point, not sure if they migrated away from that, or to that, which provides a decorator for a function. Might be another alternative, but either is fine.

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.03%. Comparing base (f701e3f) to head (89bf551).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #832      +/-   ##
==========================================
- Coverage   98.03%   98.03%   -0.01%     
==========================================
  Files         442      442              
  Lines       36112    36104       -8     
==========================================
- Hits        35401    35393       -8     
  Misses        711      711              
Flag Coverage Δ
integration 98.03% <100.00%> (-0.01%) ⬇️
unit 98.03% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.92% <ø> (ø)
OutsideTasks 98.02% <ø> (ø)
Files with missing lines Coverage Δ
tasks/tests/unit/test_process_flakes.py 98.52% <100.00%> (-0.03%) ⬇️
...sks/tests/unit/test_test_results_processor_task.py 100.00% <100.00%> (ø)

@codecov-qa
Copy link

codecov-qa bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.03%. Comparing base (f701e3f) to head (89bf551).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #832      +/-   ##
==========================================
- Coverage   98.03%   98.03%   -0.01%     
==========================================
  Files         442      442              
  Lines       36112    36104       -8     
==========================================
- Hits        35401    35393       -8     
  Misses        711      711              
Flag Coverage Δ
integration 98.03% <100.00%> (-0.01%) ⬇️
unit 98.03% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.92% <ø> (ø)
OutsideTasks 98.02% <ø> (ø)
Files with missing lines Coverage Δ
tasks/tests/unit/test_process_flakes.py 98.52% <100.00%> (-0.03%) ⬇️
...sks/tests/unit/test_test_results_processor_task.py 100.00% <100.00%> (ø)

@codecov-notifications
Copy link

codecov-notifications bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #832      +/-   ##
==========================================
- Coverage   98.03%   98.03%   -0.01%     
==========================================
  Files         442      442              
  Lines       36112    36104       -8     
==========================================
- Hits        35401    35393       -8     
  Misses        711      711              
Flag Coverage Δ
integration 98.03% <100.00%> (-0.01%) ⬇️
unit 98.03% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.92% <ø> (ø)
OutsideTasks 98.02% <ø> (ø)
Files with missing lines Coverage Δ
tasks/tests/unit/test_process_flakes.py 98.52% <100.00%> (-0.03%) ⬇️
...sks/tests/unit/test_test_results_processor_task.py 100.00% <100.00%> (ø)

Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.03%. Comparing base (f701e3f) to head (89bf551).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #832      +/-   ##
==========================================
- Coverage   98.03%   98.03%   -0.01%     
==========================================
  Files         442      442              
  Lines       36112    36104       -8     
==========================================
- Hits        35401    35393       -8     
  Misses        711      711              
Flag Coverage Δ
integration 98.03% <100.00%> (-0.01%) ⬇️
unit 98.03% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.92% <ø> (ø)
OutsideTasks 98.02% <ø> (ø)
Files Coverage Δ
tasks/tests/unit/test_process_flakes.py 98.52% <100.00%> (-0.03%) ⬇️
...sks/tests/unit/test_test_results_processor_task.py 100.00% <100.00%> (ø)

@michelletran-codecov michelletran-codecov added this pull request to the merge queue Oct 29, 2024
Merged via the queue into main with commit bcb07ef Oct 29, 2024
26 of 27 checks passed
@michelletran-codecov michelletran-codecov deleted the just_fix_timemachine branch October 29, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants